From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.devel Subject: Re: please review new branch feature/byte-unwind-protect Date: Sat, 03 Feb 2018 19:43:27 +0000 Message-ID: References: <87inbtnobf.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e082fb8e09fb7f90564540b82" X-Trace: blaine.gmane.org 1517686912 13994 195.159.176.226 (3 Feb 2018 19:41:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Feb 2018 19:41:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 03 20:41:48 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ei3h4-0003IY-CW for ged-emacs-devel@m.gmane.org; Sat, 03 Feb 2018 20:41:46 +0100 Original-Received: from localhost ([::1]:39672 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei3j5-0001FA-Ed for ged-emacs-devel@m.gmane.org; Sat, 03 Feb 2018 14:43:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ei3iv-0001CW-MC for emacs-devel@gnu.org; Sat, 03 Feb 2018 14:43:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ei3iu-00075b-PP for emacs-devel@gnu.org; Sat, 03 Feb 2018 14:43:41 -0500 Original-Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:42637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ei3iu-00074v-Fk for emacs-devel@gnu.org; Sat, 03 Feb 2018 14:43:40 -0500 Original-Received: by mail-lf0-x236.google.com with SMTP id q17so36345355lfa.9 for ; Sat, 03 Feb 2018 11:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MuwRyddXbjZ3/b8nBTFzsl0nySAb4IBCtzF9BN8kHMU=; b=CmXyDH3a3i6CSdI14zksPdAT/lkV/DoV+7ZJriF89i6msZAhMwopphfX0UTfeQ4/bo x1nRID4XTEiDrexjxzBoZGRTYwLfuCzuDzMF/tNVrEa95wQR7gyNuHPf5E05cHXr/v7s YHo69PmY4Rt6pJsr78LuSCUakOxszwX98D5m/cLJGUzDS+BhZ3tF9r8m95EDUAfZ//QB k5bn2+Nex04L8XSIQdmj/+B8tr1mRIHZo7hLsI4mxycr1f7Ek+wjdvE6dkevTF92dn7I epQDw9n57I+1zOVVXM5R/1bFe7yI8zrOe3QV6IaUWOQ7t6Ml2Me+trR15ulm18OLnL5U 1HLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MuwRyddXbjZ3/b8nBTFzsl0nySAb4IBCtzF9BN8kHMU=; b=aSZrDhZhJctEx5bjxnaZoYuEpDsL1CLsVL8K6+5dlnuKvpm3HKSZDJc2tp2t/Xbvds TgoyR/ibxeq9QQwIN5+YDdCAMuyLaaQQ+8OubGf7+dXEUJ+r6xl0SfJHMnEiml4zSgPq +S3OJ5tu0/L8lcPjcL0bNWR2L4xLMSdI+bEFKlwm7RDo8iXoeKRvKpdcciOTg4h1x5ap AttkNoulaBMf8bzqRYu3MBcVuKv+phOxZGybXL5qnSGpHNk+2QQ/j5+0ayI10RI42EQt VT+vLqqrR3WnxWXVe1iLqr9VViXo4PYB2N7p2VRBzfJcctNgYjen1ZgUTXJxImPhirRS Dunw== X-Gm-Message-State: AKwxytdD/heqeR5L6uw2wO0tdvze+Qgzr8lK516Tx6hnWlCwFitwhuTp +A//iSSRiyFQDvrl2fkXrOV6NDvhUmmq0A+3AT83DA== X-Google-Smtp-Source: AH8x224qhgzgd4/rx0aByvT4B5HjMPvvrpqguDbYSszo6jTVkzg2rHa0FTVePz/RO4CEN5B4fZtPFMn/9R987oAvzaY= X-Received: by 10.46.51.7 with SMTP id d7mr19785199ljc.78.1517687018597; Sat, 03 Feb 2018 11:43:38 -0800 (PST) In-Reply-To: <87inbtnobf.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222475 Archived-At: --089e082fb8e09fb7f90564540b82 Content-Type: text/plain; charset="UTF-8" Tom Tromey schrieb am Di., 23. Jan. 2018 um 06:21 Uhr: > > The first patch changes the C code so that a CATCHER_ALL handler sees > both signals and throws. In addition to being needed for the second > patch, this allowed some simplifications in the module code. Note that > this changes the interface exposed by internal_catch_all, but as there > is only one caller, it is easy to verify that the change doesn't matter. > This patch is a pretty uncontroversial refactoring that simplifies the codebase independently of the byte-code change, so I'd suggest you install it as-is. Thanks. --089e082fb8e09fb7f90564540b82 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Tom Tr= omey <tom@tromey.com> schrieb a= m Di., 23. Jan. 2018 um 06:21=C2=A0Uhr:

The first patch changes the C code so that a CATCHER_ALL handler sees
both signals and throws.=C2=A0 In addition to being needed for the second patch, this allowed some simplifications in the module code.=C2=A0 Note tha= t
this changes the interface exposed by internal_catch_all, but as there
is only one caller, it is easy to verify that the change doesn't matter= .

This patch is a pretty uncontroversial ref= actoring that simplifies the codebase independently of the byte-code change= , so I'd suggest you install it as-is. Thanks.
--089e082fb8e09fb7f90564540b82--