From: Philipp Stephani <p.stephani2@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: emacs-devel@gnu.org
Subject: Re: please review new branch feature/byte-unwind-protect
Date: Sat, 03 Feb 2018 19:43:27 +0000 [thread overview]
Message-ID: <CAArVCkQ1u4Fa-mv3RH+cOZGx1T-BERee=p-ogychTv18Gb6W8g@mail.gmail.com> (raw)
In-Reply-To: <87inbtnobf.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
Tom Tromey <tom@tromey.com> schrieb am Di., 23. Jan. 2018 um 06:21 Uhr:
>
> The first patch changes the C code so that a CATCHER_ALL handler sees
> both signals and throws. In addition to being needed for the second
> patch, this allowed some simplifications in the module code. Note that
> this changes the interface exposed by internal_catch_all, but as there
> is only one caller, it is easy to verify that the change doesn't matter.
>
This patch is a pretty uncontroversial refactoring that simplifies the
codebase independently of the byte-code change, so I'd suggest you install
it as-is. Thanks.
[-- Attachment #2: Type: text/html, Size: 901 bytes --]
next prev parent reply other threads:[~2018-02-03 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 5:20 please review new branch feature/byte-unwind-protect Tom Tromey
2018-01-23 8:47 ` John Wiegley
2018-01-23 15:50 ` Tom Tromey
2018-01-23 16:37 ` Stefan Monnier
2018-01-27 17:37 ` Markus Triska
2018-01-27 21:28 ` Stefan Monnier
2018-02-03 19:43 ` Philipp Stephani [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-26 7:58 Rocky Bernstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAArVCkQ1u4Fa-mv3RH+cOZGx1T-BERee=p-ogychTv18Gb6W8g@mail.gmail.com' \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).