From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Sat, 7 Dec 2019 06:45:46 +0100 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000af9686059916ae37" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="113554"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Stefan Monnier , Emacs developers To: Richard Stallman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 07 06:46:43 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idSvQ-000TMl-37 for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 06:46:40 +0100 Original-Received: from localhost ([::1]:48078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idSvO-0007i9-4f for ged-emacs-devel@m.gmane.org; Sat, 07 Dec 2019 00:46:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49770) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idSvI-0007hx-0r for emacs-devel@gnu.org; Sat, 07 Dec 2019 00:46:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idSvG-00085Y-LE for emacs-devel@gnu.org; Sat, 07 Dec 2019 00:46:31 -0500 Original-Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:37396) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idSvC-0007aS-Sa; Sat, 07 Dec 2019 00:46:27 -0500 Original-Received: by mail-qt1-x830.google.com with SMTP id w47so9475895qtk.4; Fri, 06 Dec 2019 21:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=swfOi323j0tDHiLTUBRu1B9M7dn8o2Yq0Yo8UCGbT9k=; b=Fey3oGCoMaKnOvtNWiFb3WI/W+4RNy3z5CjlNgWpfNJk00XNGyzdMXcBu/XDccQ+JL 62RFQ8sPoPA7L8rrr1+r3DbOGhDA1qyzOA6bL4NM7Avyyobp/adXYBx5a5lmlCRI3TXm qRoJQzdcwl6Fo5VvuwESxlQY2ZDYr3raYrIyZhVTi3BIdlqSsX7t8p6bTN/P04iQODbe p+fKsvSiu0nfDvHxo+AKGHRlVSxhw/Mm+GM5WowtUVTEGpR8YGQ92P6gPkav7mA4sN2O zgkgiR6JcTVpK1NYvxFIrV7ivPYlopWMMGokvwaer9XlDm1ywsWEkmZpp0nblZ7wbuoX FORg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=swfOi323j0tDHiLTUBRu1B9M7dn8o2Yq0Yo8UCGbT9k=; b=qzWARFjD80HZfWxINDbVT/2ph0wBbxbHHb2R0pd3BhBstvm8MH9SLkiK8dQjXkxB+3 ASieI+kNk9j/tbC8imXvPzGcGMPnXwa4jmlqq0f2+iC0PBSS7YUSFDYTmv0DmxGWKS6E YoEJDmGxxRa/IM0kOz2IoR8lclX9rr2O3iyLAavUVAsSb5PQK7L42g6zCGqv0KEatbz9 7YhCzKY9vszpeKO7k9AWyvp4bVXDpkhc2iZqmUdLRKJtsnF4CLnIUky0STYBUjN2AKCW 31YDlByd/VYsL9quMUC5djBIhw94YoCJMbL/Sbg4J10e+yWvf9zexyCd/BQ9lyJkhBJd I32Q== X-Gm-Message-State: APjAAAUO35FJiDb2Q3+tEHYYbHhnajy+cLVDhgF4vqEuV3ZPivXaijJH lj79QkzjU0WQN0keqGdXTzXHu5JmIf7hI7rjpiIOB4ur X-Google-Smtp-Source: APXvYqyYfjAQ5/g0inPw4F79bDn1jfiPT/4JU4/wwwFYr9U9yWWkXxYZ/XzJlIGlYVSeX6y8iGNpZ2N/TLHKNmdwzU0= X-Received: by 2002:aed:3c5b:: with SMTP id u27mr16492665qte.287.1575697582624; Fri, 06 Dec 2019 21:46:22 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::830 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243208 Archived-At: --000000000000af9686059916ae37 Content-Type: text/plain; charset="UTF-8" On Sat, Dec 7, 2019 at 5:48 AM Richard Stallman wrote: > What does Common Lisp say about the return value of 'push'? >From the Common Lisp Hyperspec: *Macro* *PUSH* *Syntax:* *push* *item place* => *new-place-value* *Arguments and Values:* *item*---an *object* <26_glo_o.htm#object>. *place*---a *place* <26_glo_p.htm#place>, the *value* <26_glo_v.htm#value> of which may be any *object* <26_glo_o.htm#object>. *new-place-value*---a *list* <26_glo_l.htm#list> (the new *value* <26_glo_v.htm#value> of *place*). *Description:* *push* <#push> prepends *item* to the *list* <26_glo_l.htm#list> that is stored in *place*, stores the resulting *list* <26_glo_l.htm#list> in *place*, and returns the *list* <26_glo_l.htm#list>. > If Common Lisp describes a certain return value for 'push', > people will tend to use it that way, Yes, though as I said, it is very rarely used, at least on our sources. 34 uses out of ~4,100. There are also a lot like (and test-1 test-2 ... (push item place)) but don't really depend on the return value of `push', they're just using `and' as a conditional. > and I think it would be > a waste of time changing all code that ever depends on that return value. At least for our sources, that time's already been wasted, whether we apply my patch or not. > It would be easier to document that return value. I tend to agree, because I don't like gratuitously discarding CL compatibility. --000000000000af9686059916ae37 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sat, Dec 7, 201= 9 at 5:48 AM Richard Stallman <rms@gnu.or= g> wrote:

> What does= Common Lisp say about the return value of 'push'?

From the Common Lisp Hyperspec:


Syntax:

push=C2=A0item pl= ace=C2=A0=3D>=C2=A0new-place-value

Arguments and = Values:

item---an=C2=A0object.

place---a=C2=A0place, the=C2=A0value=C2=A0of whic= h may be any=C2=A0obj= ect.

new-place-value---a=C2=A0list=C2=A0(the new=C2=A0value=C2=A0of=C2=A0plac= e).

Description:

push=C2=A0prepends=C2=A0item=C2=A0to the=C2=A0list=C2=A0that is stored in=C2=A0place, = stores the resulting=C2=A0list=C2=A0in=C2=A0place, and return= s the=C2=A0l= ist.


> If Common Lisp describes a certain return value for 'push&= #39;,
> people will tend to use it that way,

Yes, though as I = said, it is very rarely used, at least on our sources. 34 uses
=
out of ~4,100.

There are also a lot li= ke

(and test-1
=C2=A0 =C2=A0 =C2=A0test-2
=C2=A0 =C2=A0 =C2=A0= ...
=C2=A0 =C2=A0 =C2=A0(push item place))

but don't really d= epend on the return value of `push', they're just using `and'
as a conditional.

> and = I think it would be
> a waste of time changing all code that ever dep= ends on that return value.

At least for our sources, that time's already been wasted, whether we= apply my
patch or not.

> It would be easier to document that return value.

I tend t= o agree, because I don't like gratuitously discarding CL=C2=A0compatibility.

--000000000000af9686059916ae37--