From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Date: Thu, 17 Oct 2019 05:45:09 +0200 Message-ID: References: <20191017004602.22269.2935@vcs0.savannah.gnu.org> <20191017004604.866DF20BC2@vcs0.savannah.gnu.org> <875zkonpqm.fsf@gnus.org> <871rvcnmg1.fsf@gnus.org> <20191017024946.6b7vmup4o3v3t3w6@Ergus> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000066f5a90595130db4" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="93544"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , Emacs developers To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 05:45:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKwjc-000OBT-Qa for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 05:45:56 +0200 Original-Received: from localhost ([::1]:59348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKwja-0002nM-SO for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2019 23:45:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40805) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKwjT-0002n5-Dg for emacs-devel@gnu.org; Wed, 16 Oct 2019 23:45:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKwjS-0002rS-Ca for emacs-devel@gnu.org; Wed, 16 Oct 2019 23:45:47 -0400 Original-Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]:38041) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKwjS-0002rM-8Q for emacs-devel@gnu.org; Wed, 16 Oct 2019 23:45:46 -0400 Original-Received: by mail-qk1-x72d.google.com with SMTP id p4so613819qkf.5 for ; Wed, 16 Oct 2019 20:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HzveGQmi9rR+dtimp3wWmu6jSdaGq5A5nEbl3Ouz9f4=; b=PX7xdr7Jb3XvEl15KP2zAxLUh72eF6k1QzTSKMmNFG41PB5gN8gM1nFVXjGmQ2Ku9X Iwbwp+wN2H89csxpBquPvIqo/R0CC02cSHaEVR2Su/6zV/dVjQnCLrFyOUQDWTlNvY8j mh5+VLTTXFRlauLMIeRKdrrtB8kS2GfFkk8jKEhHRd+D3uftl3hbNBUYEuH1yg1XQn3G 3wcZBiqrAo+8DTo+0dsTKzxvfWGmm0P/wlNpbTF3oT8w5bvKjDfLxCaYjGGp0mCW3iKU Xdyanf+q4cM61YPoKURJEdfj89Gl2tEqCT6WstfCuB4q/gxcRSUOtUml2znUKZm3xbyk At8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HzveGQmi9rR+dtimp3wWmu6jSdaGq5A5nEbl3Ouz9f4=; b=YBFygEXnNNBAjW4DtFO87DJXwgLVOVCjEIC9zIIiYA4OOMJEYtdHYiEYKQcd6o7gsQ YAs/rEYewEeBa2P3kxakwnQC2lgMG321yPNutaAFUlUlbgucqw2BYiLS8rzmVwwNi1nV YcU4yM8GE0MFJrl/yzaq/TIaDHqSQD4VxOmbQNsXlu2t+i7Lo3OhedYub/batWD5YvDU 3rLXC88VD4c0FKXj7nz3x8SqwyvUZ1PHuL9pVFHKEbxd2Pu/V0bczTrKnoAgnwCmmUvr UB2uF34XCg0VTDtDaGomhlb5dw/3Fn+gejhVDq5m590eq8rZJd1HbTsopncW5/aXKFj8 Xo5A== X-Gm-Message-State: APjAAAWXcu/3uqYbSvnzwxPlA+P7AH55K0nwejjdDhD+KujkDDsqp8Za 2qNOiG+P9EPggUct+Miv66mOOj4uA2Yric7ImXI= X-Google-Smtp-Source: APXvYqxTqlJ6BcVky5SgrXGBa/UOtoorRqp4u9L+KwZanEnT7+wS2j7tmx86pWJ3aM3QQWFMEYtSUHlCnQ9RrQU+jFQ= X-Received: by 2002:a37:a487:: with SMTP id n129mr1325545qke.277.1571283945320; Wed, 16 Oct 2019 20:45:45 -0700 (PDT) In-Reply-To: <20191017024946.6b7vmup4o3v3t3w6@Ergus> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241117 Archived-At: --00000000000066f5a90595130db4 Content-Type: text/plain; charset="UTF-8" On Thu, Oct 17, 2019 at 4:50 AM Ergus wrote: > AFAIK: In lisp true means anything non-nil for most of the > purposes. Yes. And still, most predicates are defined as returning t/nil. > This change I am not sure how convenient is it. It just ads > some extra complexity to read with no benefit. There are lots of places in the sources that already use (and ... t) to normalize the result to t. It's not a lot of complexity. > Maybe it made more sense to fix the docstrings to say non-nil instead of > forcing the code to return t? That means that you're sure that there's no code out there depending on the (documented) result being t. --00000000000066f5a90595130db4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Oct 17, 2019 at 4:50 AM Ergus <spacibba@aol.com> wrote:

> AF= AIK: In lisp true means anything non-nil for most of the
> purposes.<= /div>

Yes. And still, most predicates are defined as ret= urning t/nil.

> This change I am not sure how c= onvenient is it. It just ads
> some extra complexity to read with no = benefit.

There are lots of places in the sources t= hat already use (and ... t) to normalize the result to t. It's not a lo= t of complexity.

> Maybe it made more sense to fix the doc= strings to say non-nil instead of
> forcing the code to return t?

That means that you're sure that there's no c= ode out there depending on the (documented) result being t.
--00000000000066f5a90595130db4--