From: Juanma Barranquero <lekktu@gmail.com>
To: Ergus <spacibba@aol.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring
Date: Thu, 17 Oct 2019 05:45:09 +0200 [thread overview]
Message-ID: <CAAeL0STQXAe+X+VrwcK=mZmUmig-w7i=dSGgFa6NQ0WVy-m58g@mail.gmail.com> (raw)
In-Reply-To: <20191017024946.6b7vmup4o3v3t3w6@Ergus>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Thu, Oct 17, 2019 at 4:50 AM Ergus <spacibba@aol.com> wrote:
> AFAIK: In lisp true means anything non-nil for most of the
> purposes.
Yes. And still, most predicates are defined as returning t/nil.
> This change I am not sure how convenient is it. It just ads
> some extra complexity to read with no benefit.
There are lots of places in the sources that already use (and ... t) to
normalize the result to t. It's not a lot of complexity.
> Maybe it made more sense to fix the docstrings to say non-nil instead of
> forcing the code to return t?
That means that you're sure that there's no code out there depending on the
(documented) result being t.
[-- Attachment #2: Type: text/html, Size: 894 bytes --]
next prev parent reply other threads:[~2019-10-17 3:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
2019-10-17 1:08 ` master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Lars Ingebrigtsen
2019-10-17 1:44 ` Juanma Barranquero
2019-10-17 2:19 ` Lars Ingebrigtsen
2019-10-17 2:26 ` Juanma Barranquero
2019-10-17 2:49 ` Ergus
2019-10-17 3:45 ` Juanma Barranquero [this message]
2019-10-17 3:47 ` Lars Ingebrigtsen
2019-10-17 3:59 ` Juanma Barranquero
2019-10-17 7:57 ` Eli Zaretskii
[not found] <<20191017004602.22269.2935@vcs0.savannah.gnu.org>
[not found] ` <<20191017004604.866DF20BC2@vcs0.savannah.gnu.org>
[not found] ` <<875zkonpqm.fsf@gnus.org>
[not found] ` <<CAAeL0SSg8_9vELEeH9BtC02Bpf26AVCgLhpsBSAgQ0nLzXtrMw@mail.gmail.com>
[not found] ` <<871rvcnmg1.fsf@gnus.org>
[not found] ` <<8336frdcs9.fsf@gnu.org>
2019-10-17 15:15 ` Drew Adams
2019-10-17 15:43 ` Juanma Barranquero
2019-10-17 18:02 ` Stefan Monnier
2019-10-17 18:18 ` Juanma Barranquero
2019-10-17 18:31 ` Stefan Monnier
2019-10-17 18:37 ` Eli Zaretskii
2019-10-17 19:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeL0STQXAe+X+VrwcK=mZmUmig-w7i=dSGgFa6NQ0WVy-m58g@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=spacibba@aol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).