From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Date: Thu, 17 Oct 2019 05:59:46 +0200 Message-ID: References: <20191017004602.22269.2935@vcs0.savannah.gnu.org> <20191017004604.866DF20BC2@vcs0.savannah.gnu.org> <875zkonpqm.fsf@gnus.org> <871rvcnmg1.fsf@gnus.org> <20191017024946.6b7vmup4o3v3t3w6@Ergus> <874l08m3t4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a2e4fb05951341b3" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162409"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Ergus , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 06:00:59 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKwyA-000g6e-VY for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 06:00:59 +0200 Original-Received: from localhost ([::1]:59646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKwy9-0006P8-3d for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 00:00:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42862) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKwxc-0006NB-1i for emacs-devel@gnu.org; Thu, 17 Oct 2019 00:00:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKwxa-0007wg-Nm for emacs-devel@gnu.org; Thu, 17 Oct 2019 00:00:23 -0400 Original-Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:34064) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKwxa-0007vs-Hc for emacs-devel@gnu.org; Thu, 17 Oct 2019 00:00:22 -0400 Original-Received: by mail-qt1-x830.google.com with SMTP id 3so1614862qta.1 for ; Wed, 16 Oct 2019 21:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RXwTf4uR562LceaoPQUlr0O9f8GeAHj2C2YyV0MNVJk=; b=GU7U/QPyuiNemEg7L6Xk8aoJ3PtBxYRGLyhfaH7ACZ5CxKsUiJdEh8g9XrjFGrO3qe rXavzbsn54FENMVOo1Ky0VaskJkBq6ZKpxIKnioE17NqSqHGxlrgDYhDptj6T/i1WZe2 KKj4Y9hBrTYP426EojAseB4PLj2cP6gXaD8ItifTrBXWbMH3aVYVRlEBhKEwJcJuChI5 GZwt56y0z3Zb+JQM60jrrTgssp5MpIn6SByZsTVJodpjMw/C/YIfhItvY7jT3ctoLBUj mV7XQr/vaRyPPdlWQrLQ4Kq6sBYJsUm2LLDU5ymFGmou6TWcKT+AQDtvtVi98U+ZXoAX Jokg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RXwTf4uR562LceaoPQUlr0O9f8GeAHj2C2YyV0MNVJk=; b=J4WExubt0KYe1E19kneZhGpIMiBv/a+Dd6OZkz6U8yE45C/sBrcjUBjNsdM/ffiIdZ ZaoMvGCkFygI7a1zqWiLUsE1TUpbSUGvrRoYuT7s8ue0Z3RH8Jsnq4xy9iIGVPSVYIlR XtaQYQoLYdtEgiUeYQXfsfzB/xw5lwR1CZ6YTbf5J8LnRPsDWDDM9idPO5rbPIu8iiUe paHZBw7tC699CS12HOgdEyBLQB/jwByDQDm76xcexg9JibacrzNVAxS7y4gHarcBbNLs SjG4PWRK/KSrw17QjYstwAHVdHylFIudjdVgBDGVnRzJt+Eu83KWHuhyAa/GlG7bs/xR lnUw== X-Gm-Message-State: APjAAAX7MtqgS+qo3WXtH2gGqcbE6+BhuINRpC1yu8NcpbCBHWlFSsI0 vWylZLj3yVzKwFhGNBZdoC2AK+iavdpqhVFNFD0= X-Google-Smtp-Source: APXvYqwLtHyGRBXBFuZU8FSpowB/YsBOdilmJzpE3HNhdL0wwFfWVfFl8BCTwOmE520vd8O75BdFusSAw85M/H7PyL4= X-Received: by 2002:ac8:435b:: with SMTP id a27mr1752921qtn.242.1571284821663; Wed, 16 Oct 2019 21:00:21 -0700 (PDT) In-Reply-To: <874l08m3t4.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::830 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241119 Archived-At: --000000000000a2e4fb05951341b3 Content-Type: text/plain; charset="UTF-8" > If that code existed, it would have failed, wouldn't it? So it seems > unlikely. Either that, or the users just did the (and ... t) trick to normalize the result themselves. Or it failed, but very rarely. In some cases that I've fixed, the t result can be produced through many branches of an `or', for example, and most of them already returned t, but not all. Or look at speedbar-this-file-in-vc: it had a flaw, because it promised non-nil but could in some cases return the result of `run-hook-with-args' (which is documented as having an unspecified return value). So certainly such bugs can exist and just be triggered in very unusual situations. --000000000000a2e4fb05951341b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> If that code existed, it would have failed, wouldn= 9;t it?=C2=A0 So it seems
> unlikely.

Either that, or the user= s just did the (and ... t) trick to normalize the result themselves.=C2=A0<= br>
Or it failed, but very rarely. In some cases that I've fixed, th= e t result can be produced through many branches of an `or', for exampl= e, and most of them already=C2=A0returned t, but not all.

Or look at= speedbar-this-file-in-vc: it had a flaw, because it promised=C2=A0non-nil = but could in some cases return the result of `run-hook-with-args' (whic= h is documented as having an unspecified return value). So certainly such b= ugs can exist and just be triggered=C2=A0in very unusual situations.
--000000000000a2e4fb05951341b3--