From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master 2bb0703 1/2: lisp/*.el: Force non-nil result to t, to match docstring Date: Thu, 17 Oct 2019 03:44:38 +0200 Message-ID: References: <20191017004602.22269.2935@vcs0.savannah.gnu.org> <20191017004604.866DF20BC2@vcs0.savannah.gnu.org> <875zkonpqm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005d3e140595115e40" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="63999"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 17 03:46:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKurg-000FsU-OL for ged-emacs-devel@m.gmane.org; Thu, 17 Oct 2019 03:46:08 +0200 Original-Received: from localhost ([::1]:55260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKurd-0003Mk-Tk for ged-emacs-devel@m.gmane.org; Wed, 16 Oct 2019 21:46:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41304) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKuqq-0003MZ-9R for emacs-devel@gnu.org; Wed, 16 Oct 2019 21:45:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKuqp-0003a6-AG for emacs-devel@gnu.org; Wed, 16 Oct 2019 21:45:16 -0400 Original-Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:45196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKuqp-0003Zg-2u for emacs-devel@gnu.org; Wed, 16 Oct 2019 21:45:15 -0400 Original-Received: by mail-qt1-x82c.google.com with SMTP id c21so1137576qtj.12 for ; Wed, 16 Oct 2019 18:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dsVrxl4N0sKDbM4wd8re4nuxBh/gp1ErXfSWEOHAyfY=; b=jiZ7qEz2hkULLP760uUEMJfF9B63EVJ1z2nLrHBSqDtKyjbEpjjsSBF5AM70JvAHQd 2F0UAyBKrr4W2LTEbwcXBr55H3LJ3MohRMFi8khswLgXmsb9XHSBOvQreZP64UBajdM2 /IcCE0hbI49K+P1Uxt6t3u6EfiSSjDBhaKdtzh9PSQsPwdN6f0l8bmuX7ZBsfB6BEZgo 1hEe0Y6p4zu/Txh8n/nTr4H3z60u6WHxVkJG/unXBPbvKiv5jlS8r8pQhMezkAA0kpKa JOPMbSEJ9WMduwvCIMM08V830m00S4vdY2mV8iJsmc2L+Wuomm2whihl6aaKb9uwdOlS xFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dsVrxl4N0sKDbM4wd8re4nuxBh/gp1ErXfSWEOHAyfY=; b=ff51Ui4wz1xMAv6GQIqrb3SNNThUCEruKSqxrtKn/vd71FlgWgpwD03yxwrtWx6lcf tn1Vnt+CU8eOZH2GRiXpCIz71LIb/1PVTsvdjgaRymEPLf6S8DEHMRAJ5DvkuREUyWWP 9OIhYv4b85rER0p4cBp/D4MQW+7rJldSRFOY5YD1nMBtXRtpWiVDCf5Iqdm8qZNhl431 74bG8aywqvd5C4tvC/sFmseCDWnYajjesjhHLw847eNsTAT2CtGnIXQFKuzOjzZmW53j /R+pNnEc648T5PAnR4eOl9Y9cnMou8NCRLUbnz9lF5akNjwoig3oNfhTsKR6NxoukImy y86g== X-Gm-Message-State: APjAAAXUnh0f8ImLGtxqk8SxaKn0Y/r6ZiN2phdSDJdER4J6PITBT1kJ gXgc3yNB8eG61op5lR6wWx0tD1N3BeiWyq/9ARw= X-Google-Smtp-Source: APXvYqze/qMEdzW6iFoxKM7+IFjRhlhroXtjSt0v1NIqLN1HuEyPfWefn+KKCWk4MYF0OqdMZ1QiG8MiOpC5qJaC0d8= X-Received: by 2002:ac8:35dc:: with SMTP id l28mr1327418qtb.17.1571276713703; Wed, 16 Oct 2019 18:45:13 -0700 (PDT) In-Reply-To: <875zkonpqm.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241108 Archived-At: --0000000000005d3e140595115e40 Content-Type: text/plain; charset="UTF-8" On Thu, Oct 17, 2019 at 3:08 AM Lars Ingebrigtsen wrote: > Aren't these mostly doc string bugs, though? That is, the doc string > says "t" instead of "non-nil"; it's a common bug. Depends. When the function is a predicate, t/nil makes more sense (generally speaking, there are exceptions) that non-nil/nil. In this and the other patches, I've opted for the fix (either doc fix, or code fix) that I thought it was more logical, or matched better the function's intent, or less prone to cause a bug. --0000000000005d3e140595115e40 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Oct 17, 2019 at 3:08 AM Lars Ingebrigtsen <= larsi@gnus.org> wrote:

>= Aren't these mostly doc string bugs, though?=C2=A0 That is, the doc st= ring
> says "t" instead of "non-nil"; it's a = common bug.

Depends. When the function is a predicate, t/nil ma= kes more sense (generally speaking, there are exceptions) that non-nil/nil.= =C2=A0

In this and the other patches, I've opted for the fix (ei= ther doc fix, or code fix) that I thought it was more logical, or matched b= etter the function's intent, or less prone to cause a bug.=C2=A0
--0000000000005d3e140595115e40--