From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430) Date: Mon, 2 Dec 2019 00:36:32 +0100 Message-ID: References: <20191201091356.26612.95511@vcs0.savannah.gnu.org> <20191201091358.11752207E0@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000f385330598acf0b1" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182096"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 02 00:38:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibYn6-000lGz-Be for ged-emacs-devel@m.gmane.org; Mon, 02 Dec 2019 00:38:12 +0100 Original-Received: from localhost ([::1]:56748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibYn5-0001Bu-9C for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 18:38:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38771) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibYm6-0001BZ-5G for emacs-devel@gnu.org; Sun, 01 Dec 2019 18:37:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibYm5-0006E8-1c for emacs-devel@gnu.org; Sun, 01 Dec 2019 18:37:09 -0500 Original-Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]:46107) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibYm4-0006Db-TS for emacs-devel@gnu.org; Sun, 01 Dec 2019 18:37:08 -0500 Original-Received: by mail-qt1-x831.google.com with SMTP id 38so3488505qtb.13 for ; Sun, 01 Dec 2019 15:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BPf7hWe6uTmwt3BO4kR0VqR/ELEGYo5J3zJpIvLGz9k=; b=WwFU4mZHKV0FQpXVIl43r2MIoOf63lzg2/mDD1FujBa8X+k7FtiL0c+H3AUaZF+Ai5 lsftX/gHeuSwrUbCm1Wn0pleEaU0yo1ZQxOEbgUVEpy5WPy25u5Gwze4GhT+nJQKq0u+ LqbONKJ+mcF5UsfxjRWtAEKSiHCZDb0pTbf1zD7mHVZ4bemdbxE9L0R5B31qS87lbRZQ RAaFcMik2CiBdz9XvRrh5pDpEz2x84UQLVULVg95oWlQfoDEt37fca/yeqSRbVSB9bly Vir1XWC6GexMv/Ort7R3DV0/WPwEuquWCcFPujtsQ85IgBt9OHvmkOTP8vnzbJDuZoKi encg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BPf7hWe6uTmwt3BO4kR0VqR/ELEGYo5J3zJpIvLGz9k=; b=S4kS3l3VM8tHdH7QAJ7K1Y+wDztf3pfFa0nI73gxTjMVE+0Gk8tjCPMuV8Onvz7Pq3 GXAT+gIqnD2r1/WnSiBiUwhWDqmDaaBfYQrpJCtIDsOQDtyDj2vnhb+pupsEdBvaR0+d TZpAxV5iAHJU5eiLx5l2j9C9jShXJjsvNllcquGLxIua71e/klxLVPWLOvybQJ7PkYf+ g6T4jRBTX1SkehXdquN241gTmVupvQIbKR2IfUeAhQmiedq4WVItLyKcu7DmF/XEfYWY 9jvdQmt1o7Pl3QTvxsn+D4w51gH55MfJIZBSWssZQ1RmX0af/YijzOOlyeDE8R8ee2v2 ydbg== X-Gm-Message-State: APjAAAXgQb5VyY1eBBE+Kv8KHl3qODeSKHTyi+azHZ2J9yqrF8n/IFCk wxtRP7JD6ZDPzUB3e2mizu+2MhvnUJbJ0WYtN5s= X-Google-Smtp-Source: APXvYqztvpkvpXI1v4pLHMgnTtg9I+AtzYK0ECnqQniP2ewJLOxbzJMdIdEg90Nn3Pfg0j9Fvu3s7wU85T4jvIdZNGY= X-Received: by 2002:aed:3c5b:: with SMTP id u27mr3642129qte.287.1575243427839; Sun, 01 Dec 2019 15:37:07 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::831 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242978 Archived-At: --000000000000f385330598acf0b1 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 1, 2019 at 7:29 PM Stefan Monnier wrote: > This is "broken" in the sense that it makes assumptions about how the > "multiple values" are implemented. Yes, though we've had that implementation for decades and we're not likely going to add true multiple values to elisp. > We do know that `ibuffer-split-list` returns a list, so there's no point > going through CL's multiple-values simulation. We should instead treat > it as a list and extract the elements with `pcase-let` > (or `cl-destructuring-bind`). I tried to do a minimal fix so close to branching for 27, but I can do that if you want. --000000000000f385330598acf0b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Dec 1, 2019 at 7:29 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote= :

> This is "broken" in the sense that it makes as= sumptions about how the
> "multiple values" are implemented= .

Yes, though we've had that implementation for decad= es and we're not likely going to add true multiple values to elisp.

> We do know that `ibuffer-split-list` returns a l= ist, so there's no point
> going through CL's multiple-values= simulation.=C2=A0 We should instead treat
> it as a list and extract= the elements with `pcase-let`
> (or `cl-destructuring-bind`).
I tried to do a minimal fix so close to branching for 27, but I= can do that if you want.

--000000000000f385330598acf0b1--