From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM Date: Tue, 31 Jul 2012 14:10:05 +0200 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1343736676 23090 80.91.229.3 (31 Jul 2012 12:11:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Jul 2012 12:11:16 +0000 (UTC) Cc: Emacs developers To: Glenn Morris , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 31 14:11:16 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwBIC-0000Y6-KC for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 14:11:16 +0200 Original-Received: from localhost ([::1]:47329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBIB-0006LT-Qe for ged-emacs-devel@m.gmane.org; Tue, 31 Jul 2012 08:11:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBI4-0006Kz-U2 for emacs-devel@gnu.org; Tue, 31 Jul 2012 08:11:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwBHy-0002xC-Qc for emacs-devel@gnu.org; Tue, 31 Jul 2012 08:11:08 -0400 Original-Received: from mail-yw0-f41.google.com ([209.85.213.41]:56121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwBHj-0002mI-14; Tue, 31 Jul 2012 08:10:47 -0400 Original-Received: by yhr47 with SMTP id 47so7000556yhr.0 for ; Tue, 31 Jul 2012 05:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=XMsrq3ca52Y90dyW+0d9Mw+EWtpAMJPa4u/Ff8j7+yA=; b=OA3wQi+nwIkELKQ08KwvGj63qIQrtCohOL5ayVrzrM7VR9i1To2NjNuDRHii59k1OQ 3Ot9dfru8jqpxSuJvjOAxCzClrM1fYguwKcleYMwMEtwAeEkRPsZKFKPFHhZzMrj7xDe xQARNvHtxlgh09QFtC0JvbI6i3eCvy2FRxNC8TUArGgreSbSF8auolWL7JvNKFuxd/7T d9NrDLkBaKndpmcaH06BO6iY1dREZu8dF/tSByHZmchpNT+sbJiF8CiUdvTcyENfhl28 0sXdwl6JTZzI1o9A560f6aCwJlx2swaTFNOmz9rfvm8zVDrv5IoB5IySOt0r3Xlg/FTy Lnvw== Original-Received: by 10.66.73.7 with SMTP id h7mr4143009pav.34.1343736645648; Tue, 31 Jul 2012 05:10:45 -0700 (PDT) Original-Received: by 10.143.41.21 with HTTP; Tue, 31 Jul 2012 05:10:05 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.213.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151994 Archived-At: > revno: 109306 > committer: Glenn Morris > branch nick: trunk > timestamp: Mon 2012-07-30 17:20:43 -0400 > message: > Use an include file in configure.ac's AH_BOTTOM This change brings a little trouble on Windows. 1) The new conf_pos.h unconditionally includes alloca.h, which does not work on Windows. 2) It unconditionally defines AMPERSAND_FULL_NAME, which again, is undef on Windows. To fix 2) it would be enough to #undef it on ms-w32.h, but alas, post_conf.h is included in config.in / config.nt after config_opsysfile. Both problems can be "fixed" by adding suitable #ifdef WINDOWSNT / #else / #endif to conf_post.h... except that, again, WINDOWSNT is defined in ms-w32.h, so too late. I can certainly move the definition of WINDOWSNT to the start of config.nt, but that adds a difference that I'd like to avoid (and it's ugly). Would it be possible to move AMPERSAND_FULL_NAME back to config.in? As for alloca.h, another possible fix is just to add an empty alloca.h to nt/sys. Thoughts? Juanma