unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juanma Barranquero <lekktu@gmail.com>
To: Glenn Morris <rgm@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM
Date: Tue, 31 Jul 2012 14:10:05 +0200	[thread overview]
Message-ID: <CAAeL0SSJLNByHCUJkyvcVK_aZadtr=KedbKHFJaYQ3KEYaSjKg@mail.gmail.com> (raw)
In-Reply-To: <E1SvyHP-00051u-7i@vcs.savannah.gnu.org>

> revno: 109306
> committer: Glenn Morris <rgm@gnu.org>
> branch nick: trunk
> timestamp: Mon 2012-07-30 17:20:43 -0400
> message:
>   Use an include file in configure.ac's AH_BOTTOM

This change brings a little trouble on Windows.

1) The new conf_pos.h unconditionally includes alloca.h, which does
not work on Windows.
2) It unconditionally defines AMPERSAND_FULL_NAME, which again, is
undef on Windows.

To fix 2) it would be enough to #undef it on ms-w32.h, but alas,
post_conf.h is included in config.in / config.nt after
config_opsysfile.

Both problems can be "fixed" by adding suitable #ifdef WINDOWSNT /
#else / #endif to conf_post.h... except that, again, WINDOWSNT is
defined in ms-w32.h, so too late.

I can certainly move the definition of WINDOWSNT to the start of
config.nt, but that adds a difference that I'd like to avoid (and it's
ugly). Would it be possible to move AMPERSAND_FULL_NAME back to
config.in?

As for alloca.h, another possible fix is just to add an empty alloca.h
to nt/sys.

Thoughts?

    Juanma



       reply	other threads:[~2012-07-31 12:10 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1SvyHP-00051u-7i@vcs.savannah.gnu.org>
2012-07-31 12:10 ` Juanma Barranquero [this message]
2012-07-31 12:23   ` [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM Juanma Barranquero
2012-07-31 17:09   ` Eli Zaretskii
2012-07-31 17:15     ` Juanma Barranquero
2012-07-31 17:31       ` Eli Zaretskii
2012-07-31 17:45         ` Eli Zaretskii
2012-07-31 18:01           ` Glenn Morris
2012-07-31 19:17             ` Eli Zaretskii
2012-07-31 19:28               ` Glenn Morris
2012-07-31 19:35                 ` Glenn Morris
2012-07-31 19:40                   ` Juanma Barranquero
2012-07-31 20:04                   ` Eli Zaretskii
2012-07-31 20:22                     ` Glenn Morris
2012-07-31 20:33                   ` Paul Eggert
2012-07-31 20:03                 ` Eli Zaretskii
2012-07-31 19:37         ` Juanma Barranquero
2012-07-31 19:58         ` Juanma Barranquero
2012-07-31 20:06           ` Eli Zaretskii
2012-07-31 20:18             ` Juanma Barranquero
2012-07-31 20:27   ` Glenn Morris
2012-07-31 20:36     ` Glenn Morris
2012-07-31 20:43       ` Paul Eggert
2012-07-31 21:37       ` Juanma Barranquero
2012-07-31 22:50         ` Glenn Morris
2012-07-31 22:57           ` Juanma Barranquero
2012-07-31 23:04             ` Glenn Morris
2012-07-31 23:04           ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeL0SSJLNByHCUJkyvcVK_aZadtr=KedbKHFJaYQ3KEYaSjKg@mail.gmail.com' \
    --to=lekktu@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).