From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: which-func.el unconditionally requiring edebug Date: Fri, 25 Nov 2022 19:44:28 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009340d605ee4feb37" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21731"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Magne Ingebrigtsen To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 25 19:45:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oydi0-0005Sv-B3 for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Nov 2022 19:45:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oydhK-0002fv-27; Fri, 25 Nov 2022 13:45:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oydhG-0002fM-3C for emacs-devel@gnu.org; Fri, 25 Nov 2022 13:45:11 -0500 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oydhE-0000Vt-9Z for emacs-devel@gnu.org; Fri, 25 Nov 2022 13:45:09 -0500 Original-Received: by mail-ej1-x632.google.com with SMTP id ud5so12146948ejc.4 for ; Fri, 25 Nov 2022 10:45:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=4q+GVfhHK+ZrRL4eM6PujV/JuTuEjfixTQ0+Lk2vCks=; b=I74w5Xe8RxKivcb7YoDN3cC990D5La9zyeYlCuS/AbR+zrj65bpQGs7tMV8qrHT2Do uVvXXdcnK/sp5GnWbEEszwnY/HWfFNvRV9j+UCg6TT0SwTECzfXqlv121ox8ORq6W/Zk IVqbH1rS55zOyFqLvLU6+ot8iU30YaaxORUkX07RZCbQvv2I/+vEIxp3us7xJWptW7si AQ6CQ3NEB8PVhzsD4g1lHGCdSr3uUSSi+Bk3KM5FIjEHG0tMQh+Lczb9CQB+4d/0dHz5 y5/PUcNf5QCz+YyJxLDefVEgJ/nw5vTGIs3oa8/QaeSf6yTwg7+v+U/0dfCQN0JTZHJq 6m7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4q+GVfhHK+ZrRL4eM6PujV/JuTuEjfixTQ0+Lk2vCks=; b=qTSkqswvUvclUgbza8vfvp73f5d1/oePkmb4Z66yH1fY6YSZk299KiMuhleb0s5hos kStWNqXKSGc5wlsWFJ/CSV+TqjOoNg7/MAtfwqpxJVB7ukXV9w4r3QtNWafx61Z1VFsR OLhLeSpPLS1CYvfrsxsoqiaLkKJ07LvFnHkV4pwdRIgnq0lhEwdZDmNJGSo38t8RuKVj ZiohSu+5LJrN3KEEycdHuXugLSXVKzGKqgj+sdmIvaXSb9z5w5bzQPeF/RBQGNk9IOse /tg3ARG9PIe+GmfSNEGKcTgMXyMekHtIdyy+q+036T24r6MZM7S6Q/o/UTe7jApA7QrL SODw== X-Gm-Message-State: ANoB5pkLGy7cbQ/xnzDEa84IbWYRJUUN3BPrCjjpTzOED+a3nXhQUMq+ D0esZ0A1Le8fV63W2w94UUZECXPSxDylyu2ekDF8ZbTbjqM= X-Google-Smtp-Source: AA0mqf58f18fK7JE+IZPVH7/zYULFfvB2dxbqeZv9tMTOeGzxHbiL2grqLNx3sm9j5VE69QBB+X4IOsQoWBdz5ThJTk= X-Received: by 2002:a17:906:5612:b0:7bb:8db0:53e7 with SMTP id f18-20020a170906561200b007bb8db053e7mr7355269ejq.471.1669401905673; Fri, 25 Nov 2022 10:45:05 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=lekktu@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300507 Archived-At: --0000000000009340d605ee4feb37 Content-Type: text/plain; charset="UTF-8" Lars, would it be possible to delay (require 'edebug) until lisp-current-defun-name is going to be used? commit 55cc8b040b0e3c5f97fd1386d1e9c5a120be6340 Author: Lars Ingebrigtsen Date: 2022-08-08 14:31:54 +0200 Make which-func-mode output less junk * lisp/emacs-lisp/lisp-mode.el (lisp-current-defun-name): Use edebug specs to find the name (if they exist), and default to returning the top-level symbol if there isn't a define-like form (bug#49592). I've spent quite a while trying to understand why (setq edebug-inhibit-emacs-lisp-mode-bindings t) was not working, turns out that I have (eval-when-compile (require 'which-fun)) early in my .emacs and I certainly wasn't expecting it to affect edebug. The change isn't even mentioned in the commit log. --0000000000009340d605ee4feb37 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Lars, would it be possible to delay (require 'edebug= ) until lisp-current-defun-name is going to be used?

=C2=A0 commit 55= cc8b040b0e3c5f97fd1386d1e9c5a120be6340
=C2=A0 Author: Lars Ingebrigtsen = <larsi@gnus.org>
=C2=A0 Date= : =C2=A0 2022-08-08 14:31:54 +0200

=C2=A0 =C2=A0 =C2=A0 Make which-f= unc-mode output less junk

=C2=A0 =C2=A0 =C2=A0 * lisp/emacs-lisp/lis= p-mode.el (lisp-current-defun-name): Use
=C2=A0 =C2=A0 =C2=A0 edebug spe= cs to find the name (if they exist), and default to
=C2=A0 =C2=A0 =C2=A0= returning the top-level symbol if there isn't a define-like form
= =C2=A0 =C2=A0 =C2=A0 (bug#49592).=C2=A0

I've spent quite a whil= e trying to understand why=C2=A0

(setq edebug-inhibit-emacs-lisp-mode-binding= s t)

was not working, turns out that I have=C2=A0

(eval-when-compil= e (require 'which-fun))

early in my .emacs and I certainly was= n't expecting it to affect edebug. The change isn't even mentioned = in the commit log.

--0000000000009340d605ee4feb37--