From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 4/4] Fix emacsclient to work with cygw32 Date: Thu, 29 Dec 2011 17:28:41 +0100 Message-ID: References: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1325176182 32169 80.91.229.12 (29 Dec 2011 16:29:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Dec 2011 16:29:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 29 17:29:38 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RgIrE-0001M1-St for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 17:29:33 +0100 Original-Received: from localhost ([::1]:44199 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIrE-0002UW-Ed for ged-emacs-devel@m.gmane.org; Thu, 29 Dec 2011 11:29:32 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:52828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIrA-0002Ku-Tk for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:29:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RgIr6-0000wF-96 for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:29:28 -0500 Original-Received: from mail-pz0-f41.google.com ([209.85.210.41]:57204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RgIr6-0000rR-05 for emacs-devel@gnu.org; Thu, 29 Dec 2011 11:29:24 -0500 Original-Received: by dakl33 with SMTP id l33so10650243dak.0 for ; Thu, 29 Dec 2011 08:29:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=SOfBT7nDZ3n8OdWSeBBuYn3Qp8A8GbjIhZlAlP4nzrk=; b=M+RIE5NyaVPbGk8fe7zEDGK9VO1D49f7RpH2+hQKw2nZa3Svw9OKUcBqWgyCi2KgGK eupO+LUZ43IUPxwHnEpnODwukb/KLcdibHWKPD6jmNfacVNeBRsG0WoxvcIcL3DXO7NB xzuW+qTwlzyZZIiOibN/T9V4khTIbEPdRh48k= Original-Received: by 10.68.199.231 with SMTP id jn7mr85573770pbc.125.1325176162143; Thu, 29 Dec 2011 08:29:22 -0800 (PST) Original-Received: by 10.142.247.28 with HTTP; Thu, 29 Dec 2011 08:28:41 -0800 (PST) In-Reply-To: <3a4c4669da1d97d72975e8943d7b8edff22427c1.1325166472.git.dancol@dancol.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146998 Archived-At: On Thu, Dec 29, 2011 at 15:03, Daniel Colascione wrote: > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; On Windows, = emacsclient always asks for a tty frame. > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; If running a= GUI server, force the frame type to GUI. > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when (eq windo= w-system 'w32) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; On Windows, = emacsclient always asks for a tty > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; frame. =C2= =A0If running a GUI server, force the frame > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; type to GUI.= =C2=A0(Cygwin is perfectly happy with > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; multi-tty su= pport, so don't override the user's > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; choice there= .) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (when (and (eq = system-type 'windows-nt) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0(eq window-system 'w32)) Don't you need to fix also this? ;; Delete the client's tty, except on Windows (both GUI and console), ;; where there's only one terminal and does not make sense to delete = it. (unless (eq system-type 'windows-nt) (let ((terminal (process-get proc 'terminal))) ;; Only delete the terminal if it is non-nil. (when (and terminal (eq (terminal-live-p terminal) t)) (delete-terminal terminal)))) =C2=A0 =C2=A0 Juanma