From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Tue, 3 Dec 2019 16:36:26 +0100 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009f74e80598ce771f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254334"; mail-complaints-to="usenet@blaine.gmane.org" Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 03 16:45:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icAN3-00140H-7x for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 16:45:49 +0100 Original-Received: from localhost ([::1]:55328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icAMz-0005UV-81 for ged-emacs-devel@m.gmane.org; Tue, 03 Dec 2019 10:45:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39194) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icAEf-0003NT-8v for emacs-devel@gnu.org; Tue, 03 Dec 2019 10:37:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icAEc-0004sl-4b for emacs-devel@gnu.org; Tue, 03 Dec 2019 10:37:09 -0500 Original-Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:35189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icAEb-0004pD-0p for emacs-devel@gnu.org; Tue, 03 Dec 2019 10:37:05 -0500 Original-Received: by mail-qk1-x732.google.com with SMTP id v23so3860000qkg.2 for ; Tue, 03 Dec 2019 07:37:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gfYbhInk2JIvySFZxue3Vv8iWpUZm5uWmJgbrpOHnqQ=; b=pQcIkMzU1OktSN63Uhzzu974ixukp+1KyUMK0Vp8ppcMJkEC+bideIEKadOQUR/4AX EzvTvf12yNvOyGcIbn8RJ9WJC/IYgj7Sc4SWNPjT1urFD+RYQJhahe2mXlKLFv14bZRG uRBib3hvRviiEy+9GA33OjvwgXf9woiVm7arjhtqZLIhd5QjiTTd3M232HqzCU7Rn096 +ssQylLUFZbEYPN7ejYkdZP31IK73UMij2OrwJQbgzMPlDa88vyx9A1JAcT04vZexuZO j3oWscExGyZoXqFZK5oCDav0psHIxIl8ikKoiLYy1jeyw4gUa5G8p5MVUHiSWtvEq2+T GFBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gfYbhInk2JIvySFZxue3Vv8iWpUZm5uWmJgbrpOHnqQ=; b=P3Jq07P/cq69g8xpgPC7caDFcH2m5F9a5ZOwGhnDr9N+BxI/DTJRFnG8b/p5wFOgzQ 6DL5H1V/SbEtlkG8eaaSnuU0GcxSw7ANVMrDcbG6ICKZLCWZMtBJ3pBGQ9Xk2eimpLLL 9IkXj9f9dP5TmvSmltvyUIfYgBFWscDMDLNITq0XlBfVnUo1lOv+tTCPW4eCph3g6cuf /gPfpZ4ZLMJxwVn1oCZ6RU+AHOq/IHr8gQYLI8GUBc1tvivNCUUoj9oaWHDcPh2L4LSe 5kVgdF5dNZ3XcaTn+wLpJMJmn6rcyMW5X3l+6LFeph/iuEEqE7J7U98kdHC0vT2B61z6 kEiA== X-Gm-Message-State: APjAAAUX+dgNzqrMdNn3XazxCFjaXB6S9IxN1FLgJWmI47ZMgr7+ovb2 R2BYSFEStsqbDDDG17V6dlcsGRtRd9gj97w4WQU= X-Google-Smtp-Source: APXvYqwUfBLDO1UHXRtskNTFP1aCsNRJUipPb401B4swN58MUAoBi0Pn9kY6rySraLSacoPfGG6FcIjbN6lFr/rdJi0= X-Received: by 2002:a37:48d2:: with SMTP id v201mr5699626qka.277.1575387421175; Tue, 03 Dec 2019 07:37:01 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::732 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243046 Archived-At: --0000000000009f74e80598ce771f Content-Type: text/plain; charset="UTF-8" On Tue, Dec 3, 2019 at 4:26 PM Stefan Monnier wrote: > I'd rather fix the code not to rely on the return value. Agreed, but I wasn't talking specifically about this case. There are others in the code, I think. If we don't want to document the return value of push, we should fix them all. > + (and class > + (progn (cl-pushnew class classes) t)))) Thinking about converting it to cl-pushnew is what made me look closer at this code in the first place ;-) --0000000000009f74e80598ce771f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Dec 3, 2019 at 4:26 P= M Stefan Monnier <monnier@ir= o.umontreal.ca> wrote:

> I'd rather fix the code not t= o rely on the return value.

Agreed, but I wasn't talking specifi= cally about this case. There are others in the code,
I think. If we don't want to document the return value o= f push, we should fix them all.
> =C2=A0 =C2=A0 + =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(and class
&g= t; =C2=A0 =C2=A0 + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 (progn (cl-pushnew class classes) t))))

=
Thinking about converting it to = cl-pushnew is what made me look closer at this code in
the first place ;-)

=
--0000000000009f74e80598ce771f--