unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108907: Compile marker debugging code only if ENABLE_CHECKING is defined.
       [not found] <E1Sn5bB-0004CV-TR@vcs.savannah.gnu.org>
@ 2012-07-06 17:11 ` Juanma Barranquero
  0 siblings, 0 replies; only message in thread
From: Juanma Barranquero @ 2012-07-06 17:11 UTC (permalink / raw)
  To: Dmitry Antipov; +Cc: Emacs developers

On Fri, Jul 6, 2012 at 11:20 AM, Dmitry Antipov <dmantipov@yandex.ru> wrote:

>   Compile marker debugging code only if ENABLE_CHECKING is defined.

Please, don't. Use another symbol, like it is currently done with GLYPH_DEBUG.

ENABLE_CHECKING enables assertions which, while useful for debugging,
do not negatively impact performance, or at least, not noticeably.
That's hardly the case with your marker debugging changes. My
bootstrap just went from approximately half an hour, up to more than
one hour and a half.

    Juanma



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2012-07-06 17:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1Sn5bB-0004CV-TR@vcs.savannah.gnu.org>
2012-07-06 17:11 ` [Emacs-diffs] /srv/bzr/emacs/trunk r108907: Compile marker debugging code only if ENABLE_CHECKING is defined Juanma Barranquero

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).