From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: Proposed new core library: alert.el Date: Fri, 6 Nov 2015 10:50:25 +0100 Message-ID: References: <87io5g2po3.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1141d86e96f31d0523dc2ec2 X-Trace: ger.gmane.org 1446803485 25504 80.91.229.3 (6 Nov 2015 09:51:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Nov 2015 09:51:25 +0000 (UTC) To: raman , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 06 10:51:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zudfx-0005cx-Tu for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 10:51:18 +0100 Original-Received: from localhost ([::1]:37651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zudfx-0007th-6B for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 04:51:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zudfq-0007tZ-Jb for emacs-devel@gnu.org; Fri, 06 Nov 2015 04:51:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zudfm-0003mT-74 for emacs-devel@gnu.org; Fri, 06 Nov 2015 04:51:07 -0500 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:34695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zudfl-0003mK-Re for emacs-devel@gnu.org; Fri, 06 Nov 2015 04:51:06 -0500 Original-Received: by lfgh9 with SMTP id h9so69508913lfg.1 for ; Fri, 06 Nov 2015 01:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=uA0tpBwHxxqc+oTuYU6CBlsa+VgWVg2IdLa6sy19TCY=; b=kPh/8ZKQ+z4w8CMTSwNem7DMj6FFPQwbLxK15ux5F033AZI1s9jSk2AfVhnzDSBxAq j/BwrhI3NusVSR3tizeb8MfSJLy4QdwP1JHWWbxad6+jRSIhdVJzDv08O8qTQsfbzDZ7 +e+kvhdzAO42NRBzOB9nfWmwQeSGVT6jsyhR6eAcZM6p9F4ywi4+1EojV2xMhOpcbIAe 5IbXI6NpcBQye0/dPVgvAk4DV7bJKT3x6teiNjCRMWruQK5qT9gen3oWpAPNYwKHTMq+ /VUluV5WvaKXlbKy6N8Iv2rFMkwv/eict0+pWKWtsbXC1UFsXeULvFkCNRvTnYbEjQ1N vh1w== X-Received: by 10.25.80.80 with SMTP id e77mr3845199lfb.11.1446803464973; Fri, 06 Nov 2015 01:51:04 -0800 (PST) Original-Received: by 10.25.217.132 with HTTP; Fri, 6 Nov 2015 01:50:25 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193384 Archived-At: --001a1141d86e96f31d0523dc2ec2 Content-Type: text/plain; charset=UTF-8 On Fri, Nov 6, 2015 at 3:16 AM, John Wiegley wrote: > Advice is only to be used by user code, not in core. It's the "last line" of > customization, but shouldn't be a programming style for developers. We have still some work to do. C:\...\trunk> git grep "(advice-add" lisp/*.el | grep -v advice.el lisp/emacs-lisp/cl-macs.el:(advice-add 'pcase--mutually-exclusive-p lisp/emacs-lisp/cl.el:(advice-add 'dolist :around #'cl--wrap-in-nil-block) lisp/emacs-lisp/cl.el:(advice-add 'dotimes :around #'cl--wrap-in-nil-block) lisp/emacs-lisp/cl.el:(advice-add 'declare :after #'cl--pass-args-to-cl-declare) lisp/emacs-lisp/debug.el: (advice-add function :before #'debug--implement-debug-on-entry lisp/emacs-lisp/edebug.el: (advice-add 'eval-defun :override #'edebug-eval-defun)) lisp/emacs-lisp/edebug.el:'(advice-add 'debug-on-entry :around 'edebug--debug-on-entry) ;; Should we do this? lisp/emacs-lisp/eieio.el:(advice-add 'edebug-prin1-to-string lisp/emacs-lisp/elp.el: (advice-add funsym :around (elp--make-wrapper funsym) lisp/emacs-lisp/trace.el: (advice-add lisp/eshell/em-ls.el: (advice-add 'insert-directory :around lisp/ls-lisp.el:(advice-add 'insert-directory :around #'ls-lisp--insert-directory) lisp/progmodes/elisp-mode.el: (advice-add 'macroexpand :around macroexpand-advice) lisp/ses.el:(advice-add 'copy-region-as-kill :around #'ses--advice-copy-region-as-kill) lisp/ses.el:(advice-add 'yank :around #'ses--advice-yank) lisp/uniquify.el:(advice-add 'rename-buffer :around #'uniquify--rename-buffer-advice) lisp/uniquify.el:(advice-add 'create-file-buffer :around #'uniquify--create-file-buffer-advice) --001a1141d86e96f31d0523dc2ec2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Nov 6, 2015 at 3:16 AM, John Wiegley <jwiegley@gmail.com> wrote:

> Advice is only to be used by user code, not in core. It's the &q= uot;last line" of
> customization, but shouldn't be a progra= mming style for developers.

We have still some work to do= .

C:\...\trunk> git grep "(advice-add= " lisp/*.el | grep -v advice.el
lisp/emacs-lisp/cl-macs= .el:(advice-add 'pcase--mutually-exclusive-p
lisp/emacs-lisp/= cl.el:(advice-add 'dolist :around #'cl--wrap-in-nil-block)
lisp/emacs-lisp/cl.el:(advice-add 'dotimes :around #'cl--wrap-in-= nil-block)
lisp/emacs-lisp/cl.el:(advice-add 'declare :after = #'cl--pass-args-to-cl-declare)
lisp/emacs-lisp/debug.el: =C2= =A0(advice-add function :before #'debug--implement-debug-on-entry
=
lisp/emacs-lisp/edebug.el: =C2=A0(advice-add 'eval-defun :override= #'edebug-eval-defun))
lisp/emacs-lisp/edebug.el:'(advice= -add 'debug-on-entry :around 'edebug--debug-on-entry) =C2=A0;; Shou= ld we do this?
lisp/emacs-lisp/eieio.el:(advice-add 'edebug-p= rin1-to-string
lisp/emacs-lisp/elp.el: =C2=A0 =C2=A0(advice-add f= unsym :around (elp--make-wrapper funsym)
lisp/emacs-lisp/trace.el= : =C2=A0(advice-add
lisp/eshell/em-ls.el: =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 (advice-add 'insert-directory :around
li= sp/ls-lisp.el:(advice-add 'insert-directory :around #'ls-lisp--inse= rt-directory)
lisp/progmodes/elisp-mode.el: =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(advice-add 'macroexpan= d :around macroexpand-advice)
lisp/ses.el:(advice-add 'copy-r= egion-as-kill :around #'ses--advice-copy-region-as-kill)
lisp= /ses.el:(advice-add 'yank :around #'ses--advice-yank)
lis= p/uniquify.el:(advice-add 'rename-buffer :around #'uniquify--rename= -buffer-advice)
lisp/uniquify.el:(advice-add 'create-file-buf= fer :around #'uniquify--create-file-buffer-advice)

--001a1141d86e96f31d0523dc2ec2--