* tramp-test42-auto-load failure
@ 2019-06-15 5:43 Juanma Barranquero
2019-06-15 10:28 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2019-06-15 5:43 UTC (permalink / raw)
To: Emacs developers
tramp-test42-auto-load fails on Windows because remote directories are
not being tested, for lack of a suitable default. So
'tramp-test-temporary-file-directory' is set to "NUL", and
(file-remote-p "NUL") = nil.
In fact, the test used to have
(skip-unless (tramp--test-enabled))
until commit ad99550610542f8333dc964b3bef2b9e6ad7b0f6, where it was removed.
I've sort of "fixed" it by making the test expect a failure when
'tramp--test-enabled' returns nil, because I didn't want to second
guess that commit's author, Michael Albinus.
Yet I think reverting at least part of that change would be a better
fix, because now it is "expected to fail" on Windows, while the truth
is that the test is not failing; it should simply be skipped.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tramp-test42-auto-load failure
2019-06-15 5:43 tramp-test42-auto-load failure Juanma Barranquero
@ 2019-06-15 10:28 ` Michael Albinus
2019-06-15 19:40 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2019-06-15 10:28 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
Juanma Barranquero <lekktu@gmail.com> writes:
Hi Juanma,
> Yet I think reverting at least part of that change would be a better
> fix, because now it is "expected to fail" on Windows, while the truth
> is that the test is not failing; it should simply be skipped.
I will check what's up once I could find an MS Windows machine. This
will take some days; next week I'm not in office.
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tramp-test42-auto-load failure
2019-06-15 10:28 ` Michael Albinus
@ 2019-06-15 19:40 ` Michael Albinus
2019-06-15 19:54 ` Juanma Barranquero
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2019-06-15 19:40 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: Emacs developers
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Juanma,
>> Yet I think reverting at least part of that change would be a better
>> fix, because now it is "expected to fail" on Windows, while the truth
>> is that the test is not failing; it should simply be skipped.
>
> I will check what's up once I could find an MS Windows machine. This
> will take some days; next week I'm not in office.
I've checked the history. Looks, like the removal of the skip was an
accident. In master, it is already reintroduced. So I've done in emacs-26.
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: tramp-test42-auto-load failure
2019-06-15 19:40 ` Michael Albinus
@ 2019-06-15 19:54 ` Juanma Barranquero
0 siblings, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2019-06-15 19:54 UTC (permalink / raw)
To: Michael Albinus; +Cc: Emacs developers
On Sat, Jun 15, 2019 at 9:40 PM Michael Albinus <michael.albinus@gmx.de> wrote:
> I've checked the history. Looks, like the removal of the skip was an
> accident. In master, it is already reintroduced. So I've done in emacs-26.
Great, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-15 19:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-15 5:43 tramp-test42-auto-load failure Juanma Barranquero
2019-06-15 10:28 ` Michael Albinus
2019-06-15 19:40 ` Michael Albinus
2019-06-15 19:54 ` Juanma Barranquero
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).