From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: frameset-to-register Date: Wed, 12 Feb 2014 23:59:13 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1392245999 32734 80.91.229.3 (12 Feb 2014 22:59:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Feb 2014 22:59:59 +0000 (UTC) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 13 00:00:08 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WDiml-0004bA-SB for ged-emacs-devel@m.gmane.org; Thu, 13 Feb 2014 00:00:07 +0100 Original-Received: from localhost ([::1]:41953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDiml-0004gx-GE for ged-emacs-devel@m.gmane.org; Wed, 12 Feb 2014 18:00:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35392) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDime-0004f7-2k for emacs-devel@gnu.org; Wed, 12 Feb 2014 18:00:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDimY-0001pp-OI for emacs-devel@gnu.org; Wed, 12 Feb 2014 18:00:00 -0500 Original-Received: from mail-yk0-x232.google.com ([2607:f8b0:4002:c07::232]:60301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDimY-0001pl-Jt for emacs-devel@gnu.org; Wed, 12 Feb 2014 17:59:54 -0500 Original-Received: by mail-yk0-f178.google.com with SMTP id 79so17121663ykr.9 for ; Wed, 12 Feb 2014 14:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=wH3WAYzMazllsOrj3kA/8xsicvHL7AfzQ50XAntpZRQ=; b=DDjkYFGX1udtWnmB7JpQHbn2Ea9lMRISxwQQTwSVhVPG0sWsSaEi8mmcKlHXJSc7/M RsVWIfuawkkJC7CafjFp3KSTKOJX+G6aX2wMaWOmYaddoXQGdNHLWp1DKKZ5Y2WIZdcb PNyJ3eIv0muabjs9fFY2QvKWvFUtcXmr9gr3CnLS9NjJHwb8sdzx5USeMENrI5bvGZIj nu07N7kmlVynQzXWaSKBU4EG52mALLpWpibDrQ+8cR3AAmZnkiS5T+qA0uh2e2a9JEBz f8WPgBJ4YldCEzJIOLgfTreqPWW+XegcANGE3svtQGjC+nTpOPLr8RdX2C60GIVEw2hy WXQQ== X-Received: by 10.236.133.147 with SMTP id q19mr42175429yhi.32.1392245994062; Wed, 12 Feb 2014 14:59:54 -0800 (PST) Original-Received: by 10.170.84.65 with HTTP; Wed, 12 Feb 2014 14:59:13 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4002:c07::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169571 Archived-At: I'd like to commit this small patch, which basically makes the output of list-registers/view-register a bit more informative for framesets. It's not a bug fix, but OTOH, frameset-to-register is a new feature by itself and this is just making the feature a bit better. OK to install, or do I wait for the unfreezing? J === modified file 'lisp/frameset.el' --- lisp/frameset.el 2014-02-11 20:48:23 +0000 +++ lisp/frameset.el 2014-02-12 22:42:11 +0000 @@ -1223,6 +1223,16 @@ (set-frame-selected-window frame window) (with-current-buffer buffer (goto-char position)))))))) +(defun frameset--print-register (data) + "Print basic info about frameset stored in DATA. +Called from `list-registers' and `view-register'. Internal use only." + (let* ((fs (aref data 0)) + (ns (length (frameset-states fs)))) + (princ (format "a frameset (%d frame%s, saved on %s)." + ns + (if (= 1 ns) "" "s") + (format-time-string "%c" (frameset-timestamp fs)))))) + ;;;###autoload (defun frameset-to-register (register) "Store the current frameset in register REGISTER. @@ -1240,7 +1250,7 @@ ;; in the current buffer, so record that separately. (frameset-frame-id nil) (point-marker)) - :print-func (lambda (_data) (princ "a frameset.")) + :print-func #'frameset--print-register :jump-func #'frameset--jump-to-register))) (provide 'frameset)