From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: master a6b5985: Avoid duplicated character classes in rx Date: Fri, 6 Dec 2019 21:11:28 +0100 Message-ID: References: <20191203142243.9552.27513@vcs0.savannah.gnu.org> <20191203142246.0615C20A2B@vcs0.savannah.gnu.org> <79A83C7D-610F-4CA4-B5E9-7F11FD8A9365@acm.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e1507705990ea8c6" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="172510"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Stefan Monnier , Emacs developers To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 06 21:12:54 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idJy9-000imT-TA for ged-emacs-devel@m.gmane.org; Fri, 06 Dec 2019 21:12:54 +0100 Original-Received: from localhost ([::1]:44944 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idJy8-0001Z2-5C for ged-emacs-devel@m.gmane.org; Fri, 06 Dec 2019 15:12:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36365) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idJxS-0001Yh-2s for emacs-devel@gnu.org; Fri, 06 Dec 2019 15:12:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idJxQ-0005lM-Q3 for emacs-devel@gnu.org; Fri, 06 Dec 2019 15:12:09 -0500 Original-Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:45846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idJxO-0005Y9-KO; Fri, 06 Dec 2019 15:12:06 -0500 Original-Received: by mail-qv1-xf2d.google.com with SMTP id c2so359639qvp.12; Fri, 06 Dec 2019 12:12:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s7/9aC/z8hT9NHcp+/k7df6rd83HaPaVc8C5GeN6YtY=; b=Y0F2CF4C1FBMzDiherLOFp/s7TXTHHCqzRk45InlmS5RUIfAER+aMpLGF3UXRSG7fh +Cl/cWCmhxY88z8D6VWYaC1Ab5S/LxI37PxcWb0FwcTy+duqiv9Y2zzIh1QnnMCuI7rF ta6180HBUgK0+qbY74lFBBmcwoQYqIz7xH1aNrTyn4PZriNf8R3RJSepX4F7AemZJOL0 DJBrI24iEbSwUOliP+B7/R/mRJiP20J89n4mnim6QghICactnTxzYxA7joI4xWfZzhHh iaKUsgGFaYNSGSNIHtr/wTN8BYTm4kjjs53z5cV01PQRrj8C+th2IbkD/66qZcdw4AOt gmIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s7/9aC/z8hT9NHcp+/k7df6rd83HaPaVc8C5GeN6YtY=; b=KfaBDWsXw5KhPPpuklrjRTJoZY+QqyOcfWV29jtlW+6EHS7Y8vSySTDVe5w+yY2Ki8 QiWZmHvKW734BcXOkM1GjJSZSFSxVPm1KUUKQrjzbh2CmrBBEFhQzY3tSbsSxO+DnUOb eSYhZdwtISgi5ccK3a4BH3eIVp6lB4QWAq04AK8bbWhAG6lWs00J+MPauYBkkqEdKdLx ExHrUyKI4TboVAzXRJJhCSyrZ2QBFrutmxPwDMT6B+sYLCxO3g0pLX3URwwNZoqK4zkW VbVVcBcIeJ6smAOwSN7l9TIBAkkCvYFzqFKkdG/QQwzzi8jE2tfpdlYQRT+CTLOhNbP6 l5wQ== X-Gm-Message-State: APjAAAW6V5ciPtJsQtXNwhVBwzVNuduHxPDDTSrlxVqlbXVzczGQ7HU1 b2fhcm/lG8l4iW9Uupt8l00i94qS74obi1It2no= X-Google-Smtp-Source: APXvYqw4SRfscPqrTVf43zqzgZbAUESPbzvFytG2GLULdE6xj1MXXpKgvdHNVn8Ni52DcFFnJm8MIaStPk6EdjYC5DI= X-Received: by 2002:a0c:aacc:: with SMTP id g12mr14595723qvb.217.1575663125482; Fri, 06 Dec 2019 12:12:05 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::f2d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243197 Archived-At: --000000000000e1507705990ea8c6 Content-Type: text/plain; charset="UTF-8" On Fri, Dec 6, 2019 at 8:47 PM Drew Adams wrote: > FWIW, I disagree that it's necessary, or even worthwhile/helpful, > to avoid using the return value of `push'. > > And I think the return value should be documented. Well, I would perhaps agree, for CL compatibility' sake. But I think this is, up to a point, just bikeshedding. As shown, in 99,92% of cases the return value is not used, and in the 0,08% that it is used, it's just to avoid (progn (push value variable) variable) or (progn (push value variable) t) And it's a fact that, although push's return value *is* documented in CL, it has never been so in Emacs, at least going back to cl.el in Emacs 20 (even back then, there were just vague promises that it was similar to `setf'). So it'd be nice if it were documented, but it is not, and the few places that use it can easily be fixed. No big deal, not worth discussing it IMO. > (This is like not documenting the return value of `progn' or `setq`'. ;-)) The return value of `progn' is part of its interface and use. As for `setq', it wouldn't be earthshaking if it wasn't documented. --000000000000e1507705990ea8c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Dec 6, 2019 at 8:47 PM Dr= ew Adams <drew.adams@oracle.com= > wrote:

> FWIW, I disagree that it's necessary, or ev= en worthwhile/helpful,
> to avoid us= ing the return value of `push'.
>
> And I think the return = value should be documented.

Well, I would perhaps agree, for CL comp= atibility' sake. But I think
= this is, up to a point, just bikeshedding. As shown, in 99,92% of cases
the return value is not used, and in= the 0,08% that it is used, it's
just to avoid=C2=A0

=C2=A0 (progn (push value variable) v= ariable)

or

=C2=A0 (progn (push value variable)= t)

And it's a fact that, although push's return value *is* = documented in
CL, it has never be= en so in Emacs, at least going back to cl.el in
Emacs 20 (even back then, there were just vague promises tha= t it was
similar to `setf').<= br>
So it'd be nice if it were documented, but it is not, and the fe= w
places that use it can easily b= e fixed. No big deal, not worth
d= iscussing it IMO.

> (This is like not documenting the return valu= e of `progn' or `setq`'. ;-))

The return value of `progn'= ; is part of its interface and use. As
for `setq', it wouldn't be earthshaking if it wasn't docu= mented.

--000000000000e1507705990ea8c6--