From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: which-func.el unconditionally requiring edebug Date: Wed, 7 Dec 2022 19:09:30 +0100 Message-ID: References: <83k033451k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000082fa6105ef40d471" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 19:10:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2ysi-0006wv-L7 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 19:10:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2ys0-0001Pr-BK; Wed, 07 Dec 2022 13:10:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2yry-0001PZ-Mk for emacs-devel@gnu.org; Wed, 07 Dec 2022 13:10:10 -0500 Original-Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2yrw-0003jY-91; Wed, 07 Dec 2022 13:10:10 -0500 Original-Received: by mail-ej1-x630.google.com with SMTP id n21so15868004ejb.9; Wed, 07 Dec 2022 10:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WgghlXgMSUYQ/nkKRi4SqbXTYZkZZ8GpEP3w6MzQKxY=; b=npvR2n9PATq57UxAzltNmwbGYlRy+71du0jC6jGxJ8LIiQdWm3IOK12blSGFLAiwXb dwkXh2thhzTxnh+bmjH6zaB4uDI70Nsd0u1p2QxFZuAbTpYH9ktb+BpvLFUD85ADQZv7 gQSjVnvF1EAr8fbRcx6Q3ImqcGB/ihgpfVlidKUuxcGkEBbNI9Q28wq2eomp1XLT/mHC 3g1KLBBo+0CRwTZcNPYKG5vJTR65v2qVe+OBc5fHQ2xfdzUa1qOKsHXGsYpBnFwCVUKq VeAeszKfS6CKbHiIw5lSAPajszyXerOs5kV1d7ZouJbsO0pc8VOvNwhY5JylhfKrcX5L kgUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WgghlXgMSUYQ/nkKRi4SqbXTYZkZZ8GpEP3w6MzQKxY=; b=o4JrDH98SmAMvOt+YYChTY6Jt7LBYWVsB/1MUG/c2+maIrEOac1998QJH4AyzeQMft 4tnl6T3G7lU6uP4KlII8P3G6CN4elbrJ3acRlIerDaODqijF/c4+KjUq7svz6Vcb5ArV bPVqp2dvdSpnawweL/UEtJMhAEkeHJniXC2S/KcaKeqseUJ/w20BWaLVrwctBLsig3ni iVAthxeMeghMQramYbd5Nb5Hz9Bcmk1ta4WkzqVl+KikHEpp6LCdjazE4VXallyuL7F4 Ajm7ibrbej5klEKTnVygz8eOM3hDG0VcCNwpT1uTHjzWxNT5emowmQ6t4j/RxWaHeySM CZdQ== X-Gm-Message-State: ANoB5pmzcyDFTE83UUJCUMKhLWnUf7YvR4PAf4iARSSUJXeu8N+VRAI8 DNT3+BM6x/WJBIS7geB+ZwAtUk2UJmCNAh17kJaDjcx1Tyk= X-Google-Smtp-Source: AA0mqf5V1u8Ozb5q17SrtL6rxD2E6rqJ9fYJrS4kAg9UCPj0gMEoW40ByJmZ2NKb2/LPpNCNqdIdDl00z1BdjJcTskA= X-Received: by 2002:a17:906:1310:b0:7c0:c5e9:634d with SMTP id w16-20020a170906131000b007c0c5e9634dmr20080646ejb.220.1670436605850; Wed, 07 Dec 2022 10:10:05 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=lekktu@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301022 Archived-At: --00000000000082fa6105ef40d471 Content-Type: text/plain; charset="UTF-8" In fact, I think the (require 'edebug) in which-func.el is leftover code. I didn't realize that Lars had in fact reverted that patch, sort of. In 55cc8b040b (2022-08-08), he modified lisp-mode.el (mentioned in the commit log), and also which-func.el and lisp-mode-tests.el (these are not mentioned). And then, in 48b0f2606b (2022-08-23), he removed just the changes to lisp-mode.el, but he left the new tests and the change in which-func.el. His reverting lisp-mode.el left behind a few little changes, but he removed all references to edebug-form-spec, so there's no point now to the one-line change to which-func.el and it should be reverted too, I think. --00000000000082fa6105ef40d471 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In fact, I think the (require 'edebug) in which-func.el = is leftover code. I didn't realize that Lars had in fact reverted that = patch, sort of.

In=C2=A055cc= 8b040b (2022-08-08), he modified lisp-mode.el (mentioned in the commit log)= , and also which-func.el and lisp-mode-tests.el (these are not mentioned).<= /font>

And then, in=C2=A048b0f2606b= (2022-08-23), he removed just the changes to lisp-mode.el, but he left the= new tests and the change in which-func.el.

His reverting lisp-mode.= el left behind a few little changes, but he removed all references to edebu= g-form-spec, so there's no point now to the one-line change=C2= =A0to which-func.el and it should be reverted too, I think.
--00000000000082fa6105ef40d471--