unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames.
       [not found] ` <20190628132219.71656209C7@vcs0.savannah.gnu.org>
@ 2019-06-28 14:32   ` Stefan Monnier
  2019-06-28 15:31     ` Juanma Barranquero
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-06-28 14:32 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: emacs-devel

> +         (uri-prefix (if (eq (aref file 0) ?/) "file://" "file:///")))

BTW, `grep "file://" **/*.el` gives me the impression that we likely
have similar problems elsewhere in the code.  Someone™ should introduce
a helper function that does this right and then use it everywhere else.


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames.
  2019-06-28 14:32   ` [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames Stefan Monnier
@ 2019-06-28 15:31     ` Juanma Barranquero
  2019-06-28 15:43       ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Juanma Barranquero @ 2019-06-28 15:31 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Emacs developers

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Fri, Jun 28, 2019 at 4:32 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> Someone™ should introduce
> a helper function that does this right and then use it everywhere else.

Yep. I'lll look into making a patch for the trunk.

[ Does anyone still call it "trunk" or it is now just "master"? Am I uncool
/ too old fashioned for using "trunk"? ;-) ]

[-- Attachment #2: Type: text/html, Size: 532 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames.
  2019-06-28 15:31     ` Juanma Barranquero
@ 2019-06-28 15:43       ` Stefan Monnier
  2019-06-29 10:10         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2019-06-28 15:43 UTC (permalink / raw)
  To: Juanma Barranquero; +Cc: Emacs developers

>> Someone™ should introduce
>> a helper function that does this right and then use it everywhere else.
> Yep. I'lll look into making a patch for the trunk.

That'd be nice.

> [ Does anyone still call it "trunk" or it is now just "master"? Am I uncool
> / too old fashioned for using "trunk"? ;-) ]

FWIW my local branch tracking `origin/master` is called `trunk` and is
checked out in a worktree called `trunk`.  So I think we're fashionably uncool.


        Stefan




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames.
  2019-06-28 15:43       ` Stefan Monnier
@ 2019-06-29 10:10         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-29 10:10 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Juanma Barranquero, Emacs developers

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> [ Does anyone still call it "trunk" or it is now just "master"? Am I uncool
>> / too old fashioned for using "trunk"? ;-) ]
>
> FWIW my local branch tracking `origin/master` is called `trunk` and is
> checked out in a worktree called `trunk`.  So I think we're
> fashionably uncool

One of us!  One of us!

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-29 10:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20190628132216.16744.46201@vcs0.savannah.gnu.org>
     [not found] ` <20190628132219.71656209C7@vcs0.savannah.gnu.org>
2019-06-28 14:32   ` [Emacs-diffs] emacs-26 bfc7c6e: * test/lisp/url/url-file-tests.el (url-file): Fix for POSIX filenames Stefan Monnier
2019-06-28 15:31     ` Juanma Barranquero
2019-06-28 15:43       ` Stefan Monnier
2019-06-29 10:10         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).