From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Tue, 3 Feb 2015 12:13:43 +0000 Message-ID: References: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1422965639 18196 80.91.229.3 (3 Feb 2015 12:13:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2015 12:13:59 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 03 13:13:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIcMZ-0000Nk-MJ for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 13:13:51 +0100 Original-Received: from localhost ([::1]:58929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIcMY-0001rc-VT for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 07:13:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIcMT-0001p4-5e for emacs-devel@gnu.org; Tue, 03 Feb 2015 07:13:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIcMR-0003q7-Np for emacs-devel@gnu.org; Tue, 03 Feb 2015 07:13:45 -0500 Original-Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:51421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIcMR-0003pz-JT for emacs-devel@gnu.org; Tue, 03 Feb 2015 07:13:43 -0500 Original-Received: by mail-oi0-f51.google.com with SMTP id x69so48809628oia.10 for ; Tue, 03 Feb 2015 04:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=nNA3iohgUeec7H2hhYNvgGSgaFOyNGxtjskZG1EF5iU=; b=lLGgc9k0+5JvodL1ZuWChmWQ/LSw5VuQ2nuJ49tVXWrQZjsnB5eq3kfTpVHFCr3jA1 bOjxR6LmtXGm0szIvbqAfOrm75M7mH4Ft9DOfQk5DsEWO+AmVTE2/iSKEDsU4K4a3/bz YW14KitxvdnAnmTmKcY+D/86QP2dA56p93T0b0sbfSsPHii7cymZfu2z9UsRzAoik9hp lgiTGmh/WW4onYmE8Rgrn5w7N+Zg/3QQhPJ78k97bz2OblDJfejyFz4xnkYZakPKyoV5 Zz9EqkK2AkWNzKJ9EVyre7qjjo8z1e9Xy4lGGvpPjo7B/7r9KQOih7emAuA6PlUJC1Hb ZouQ== X-Received: by 10.60.179.37 with SMTP id dd5mr15078410oec.4.1422965623254; Tue, 03 Feb 2015 04:13:43 -0800 (PST) Original-Received: by 10.76.125.1 with HTTP; Tue, 3 Feb 2015 04:13:43 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: ZHHvuq_Sc9nHjNZHf1y0W8i1mlc X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182324 Archived-At: If that package is only used for testing, you can also just not merge it into elpa and do your testing elsewhere (e.g. Travis+github). That's what I did with Names, because the tests involved a lot of packages from other people with a ton of changes made by me. I'm not saying I couldn't put those inside the Elpa/package/ directory, but it was easier this way than to worry about copyrights. I can go into the `git' details necessary for this if you'd like. 2015-02-03 5:57 GMT+00:00 Jackson Hamilton : > On the "Copyright (C) 2014 Johan Andersson", are you suggesting I change the > copyright notice in ert-async.el myself, or that I should contact the author > and tell him to change it? > > In either case that seems inappropriate. > > context-coloring/languages/javascript/libraries/ also includes 3 JavaScript > libraries with their own copyright notices. These appear to be licensed > under the FreeBSD license. Should they be handled specially? > > Regards, > Jackson > > On Mon, Feb 2, 2015 at 9:58 AM, Stefan Monnier > wrote: >> >> > which included 247 commits. I am not sure if these should be squashed, >> > but >> > based on the commit log it seems like this subtree approach is how other >> > people are managing their externally-maintained packages, so I assume it >> > is >> > okay to add the whole history. >> >> Indeed, it's OK to keep the history. >> >> > On top of that, I added 2 patches so that I could test ELPA locally. I >> > was >> > able to install my package via a "local-elpa" as described in the >> > README. >> > The patches for that are attached in this email. >> >> I think the hydra-test.el has been fixed by someone else in the >> mean time. As for your change: >> >> > +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan >> > Andersson >> >> I think this change is incorrect. IIUC this is johan.rejeep@gmail.com >> we're talking bout, and he signed the copyright assignment forms, so >> the line in ert-async.el should say "Copyright (C) 2014 Free Software >> Foundation, Inc" (at which point you won't need any change to >> copyright_exceptions). >> >> >> Stefan > >