unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Oleh Krehel <ohwoeowho@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Is there a way to inhibit message3 from Elisp?
Date: Wed, 22 Apr 2015 00:25:09 +0100	[thread overview]
Message-ID: <CAAdUY-LXeoFXL9QQFbUhM_=cTPM3a8k-=cyry2+zLq97EW=vqg@mail.gmail.com> (raw)
In-Reply-To: <87a8y1l3ho.fsf@gmail.com>

That C code is a little hard for me to understand, but it looks like
you're inhibitting both echoing (minibuffer) and logging (messages
buffer). If that's the case, please don't inhibit the latter.

2015-04-21 19:50 GMT+01:00 Oleh Krehel <ohwoeowho@gmail.com>:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> My particular use-case is that I'm doing completion in the minibuffer
>>> with ivy.el, calling `shell-command-to-string' in the `post-command-hook'.
>>> And when I enable `while-no-input' in my function, my minibuffer
>>> contents get rudely interrupted by `call_process_cleanup' saying:
>>>> "Waiting for process to die...done"
>>> I'm sure that this message is needed and appericated,
>>
>> Actually, I'm not.  IIUC this message appears if a call-process is
>> interrupted before the subprocess dies.   I think this message in not
>> desired in general.  It's OK to emit such a message if call-process ends
>> up waiting a non-negligible amount of time for the subprocess to die
>> (so as to explain to the user why Emacs is not responding), but for the
>> usual case where wait_for_termination returns quickly, we should not
>> emit any message at all.
>>
>> Patch welcome to fix this problem.
>
> Please check the scratch/inhibit-message3 branch.
> I don't have experience with Emacs C code, let me know if I'm doing
> something in a silly way.
>
> I got this code to work as I expect:
>
> (progn
>   (setq inhibit-message t)
>   (message "foo")
>   (setq inhibit-message nil))
>
> However, this doesn't work:
>
> (let ((inhibit-message t))
>   (message "foo"))
>
> And I don't know why.
>
> Oleh
>



  reply	other threads:[~2015-04-21 23:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 13:37 Is there a way to inhibit message3 from Elisp? Oleh Krehel
2015-04-21 17:17 ` Stefan Monnier
2015-04-21 18:50   ` Oleh Krehel
2015-04-21 23:25     ` Artur Malabarba [this message]
2015-04-22  6:00       ` Oleh Krehel
2015-04-22 10:53     ` Eli Zaretskii
2015-04-22 11:55       ` Oleh Krehel
2015-04-22 12:24         ` Eli Zaretskii
2015-04-22 12:50           ` Oleh Krehel
2015-04-22 13:01             ` Eli Zaretskii
2015-04-22 13:51           ` Stefan Monnier
2015-04-22 13:48             ` Oleh Krehel
2015-04-22 17:39             ` Artur Malabarba
2015-04-22 20:20               ` Stefan Monnier
2015-04-22 12:42         ` Artur Malabarba
2015-04-22 17:22         ` Artur Malabarba
2015-04-22 17:20           ` Oleh Krehel
2015-04-22 13:53     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-LXeoFXL9QQFbUhM_=cTPM3a8k-=cyry2+zLq97EW=vqg@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).