From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add file-dwim. Date: Sun, 18 Oct 2015 20:12:27 +0100 Message-ID: References: <87d1wcrzuu.fsf@T420.taylan> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1445195568 2083 80.91.229.3 (18 Oct 2015 19:12:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Oct 2015 19:12:48 +0000 (UTC) Cc: emacs-devel To: =?UTF-8?B?VGF5bGFuIFVscmljaCBCYXnEsXJsxLEvS2FtbWVy?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 18 21:12:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZntNs-0002Lv-QG for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 21:12:44 +0200 Original-Received: from localhost ([::1]:35242 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZntNr-0003zK-Ed for ged-emacs-devel@m.gmane.org; Sun, 18 Oct 2015 15:12:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZntNd-0003zC-QM for emacs-devel@gnu.org; Sun, 18 Oct 2015 15:12:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZntNc-0000FC-VO for emacs-devel@gnu.org; Sun, 18 Oct 2015 15:12:29 -0400 Original-Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:36625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZntNc-0000F6-NB for emacs-devel@gnu.org; Sun, 18 Oct 2015 15:12:28 -0400 Original-Received: by lbcao8 with SMTP id ao8so127794957lbc.3 for ; Sun, 18 Oct 2015 12:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=DqylCj/e+kvsQ4yk5jzOeH4uiRjdsNsExAbAKEfVR/s=; b=TvtWgXAYcw6PTBZx6VCP5t8ZV2BJEgCU85fLQ86XdL5JohaWwbM0gAYzIbBB/TssIl qWZPDX0iJWfQOty77IZ/ztxZeCvCcoif6umcvAEU3EDE7y3g9s+radrp0ZebYUCemsTK THXimEqOAQ3JKu0JhGsEh+M04qzFG8Uji2i9uohXyMI5yxo1PczW/Fb0cKwMYrVm7W39 DrheziApMvG6r3dcvizvwxhL/kuLJa4GMb5e/oAJSfcIRYeczdWzclQA8dRKYFYrwIL4 niRTm5FjPPaUlWan5QwhxdHRDRvbifUg2Cj3OUMQSlfRAONh1H8Wh6qcquPnyqNAjCdt 3J8A== X-Received: by 10.112.145.232 with SMTP id sx8mr8233492lbb.4.1445195547864; Sun, 18 Oct 2015 12:12:27 -0700 (PDT) Original-Received: by 10.25.22.197 with HTTP; Sun, 18 Oct 2015 12:12:27 -0700 (PDT) In-Reply-To: <87d1wcrzuu.fsf@T420.taylan> X-Google-Sender-Auth: wGVpJ13GWvtyqp5ytElH_Sfrynw X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192003 Archived-At: > + :group 'file-dwim) These :group entries are redundant. It is a (poorly documented) feature that all defcustoms following a defgroup belong to that defgroup. > +;; (defun play-video-file (file) > +;; (shell-command (concat "my-video-player " (shell-quote-argument file)))) Why not say that the cdr of an entry in `file-dwim-action-list' can also be a list like ("command" "arg1" "arg2"), in which case it used in `start-process' with the file-name at the end? For instance: (add-to-list 'file-dwim-action-list (list (rx "." (or "mp3" "flac" "aac" "wav") eos) "mplayer")) I think that would be very valuable, as this sounds like the common use for this package.