From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Fri, 11 Dec 2015 16:00:27 +0000 Message-ID: References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1449849686 22275 80.91.229.3 (11 Dec 2015 16:01:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Dec 2015 16:01:26 +0000 (UTC) Cc: Alan Mackenzie , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 11 17:01:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7Q7p-00070k-5m for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 17:00:53 +0100 Original-Received: from localhost ([::1]:48299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Q7o-00065o-Gz for ged-emacs-devel@m.gmane.org; Fri, 11 Dec 2015 11:00:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Q7U-00065K-2t for emacs-devel@gnu.org; Fri, 11 Dec 2015 11:00:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7Q7T-0004cz-25 for emacs-devel@gnu.org; Fri, 11 Dec 2015 11:00:31 -0500 Original-Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:36123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Q7Q-0004bs-FM; Fri, 11 Dec 2015 11:00:28 -0500 Original-Received: by lbblt2 with SMTP id lt2so73306085lbb.3; Fri, 11 Dec 2015 08:00:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=n+x5v24OHTbziRAHtVk3cmU4YuQr/wYLQPcyIeZscvY=; b=OFoiSBhZpTl0VDNDib6xR8awzaLfg7FDKShCZIO1nAFAJpnp7E+VJofhydgqaa2akF kktnPZSmGITkjzuCtbfPrhaTBx3uSwXQQeAzgJXvd0LiELiHlHsZj0n1A+5DSU4IW9KD YivqvBVP/3Jgu2zkhl0Y/ZExdHUG8OPDUmhEklrQ8RL3QyuaTW1rYLVT303LhiJbCOXf fhKFwsk49xwVw96PqwO8yZdjX3WmwtTCPA05F9ZP3SrEZ71/ZAkhi5/tPE6u6lN4gOkv 4Yo4XuDe3TFt+mkNnsW2d1Vu1rm2h2eky/LBdyZmDqKBl68WIoNyipxu/ezwbVQoO8pl U4Nw== X-Received: by 10.112.161.33 with SMTP id xp1mr8168952lbb.141.1449849627176; Fri, 11 Dec 2015 08:00:27 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Fri, 11 Dec 2015 08:00:27 -0800 (PST) In-Reply-To: <83y4d16txk.fsf@gnu.org> X-Google-Sender-Auth: iotdYyzHPwKrLohDsmuvEhniddg X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196118 Archived-At: 2015-12-11 12:39 GMT+00:00 Eli Zaretskii : > For example, start with isearch-mode, and then try to figure out what > each one of the following variables are in what use cases: > regexp-function and search-default-regexp-mode (as a function). You > will see that each one can be assigned to a variable that names a > function that has a default value that can be a function that... I didn't reply to your initial message for lack of time. I can add some comments here and there on the parts I understand. (some time in the coming months) > Similarly with other isearch commands. This makes the source > impenetrable to uninitiated, much harder than just stepping with > Edebug through the code. IMO, if it is easier to understand code by > stepping through it in a debugger than by reading it, that code must > be refactored or documented the heck of. Honestly, I'd love to overhaul isearch. But I couldn't do it backwards-compatibly.