From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 78ed9a1: packages/transcribe.el: Add native discourse analysis in elisp Date: Tue, 8 Dec 2015 18:12:38 +0000 Message-ID: References: <20151208162519.32321.71630@vcs.savannah.gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1449598368 13415 80.91.229.3 (8 Dec 2015 18:12:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Dec 2015 18:12:48 +0000 (UTC) To: emacs-devel , David Gonzalez Gandara Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 08 19:12:46 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6Mkn-0001GM-0u for ged-emacs-devel@m.gmane.org; Tue, 08 Dec 2015 19:12:45 +0100 Original-Received: from localhost ([::1]:32912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Mkm-000137-Cl for ged-emacs-devel@m.gmane.org; Tue, 08 Dec 2015 13:12:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Mki-00012s-Ht for emacs-devel@gnu.org; Tue, 08 Dec 2015 13:12:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6Mkh-0005u1-Nq for emacs-devel@gnu.org; Tue, 08 Dec 2015 13:12:40 -0500 Original-Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:36206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6Mkh-0005tZ-I5 for emacs-devel@gnu.org; Tue, 08 Dec 2015 13:12:39 -0500 Original-Received: by lbblt2 with SMTP id lt2so15907922lbb.3 for ; Tue, 08 Dec 2015 10:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=yIzsD9MbQtSHO+AnFN4tS0hmfP06A3Ke2R78jwoi/aM=; b=WnPz1VaFQ7j8y+s9c9VLPXoIf317ja4Uv515gmM9JfJLXHrRTrRhmq2KuEd6KmGhz4 PxyTHDwi8YbXu1CQi+06LcZ/tARvQt4qlZ2anBPg4Qs8/1RSlNvrcuxx3YiWb9jiUB8D 0fPhuhK2qkmH/QjVjTfjfV7eXOm1UMTIqVEdFVK5gLx18qdXhyn45DzZkPyyBXUObMr8 m88vsSRFkLaY3uOK/C+1He9lRNO5ukccchgK+ZiSEcDDWliNJdguIfDBhP7JFktvqDw7 ohh168fBhxfzjUcpM2C7/zC5ZpumgbtMtVksplqCeoQrhQYZjiOuRP1J1o32UfWM4z69 9uDg== X-Received: by 10.112.126.106 with SMTP id mx10mr554879lbb.3.1449598358457; Tue, 08 Dec 2015 10:12:38 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Tue, 8 Dec 2015 10:12:38 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: k3Vt9LYu4bFuhGR2AFpeUkVgTvk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195983 Archived-At: Hi David 2015-12-08 16:25 GMT+00:00 David Gonzalez Gandara : > +(defun transcribe-analyze (episodenumber personid) > + "Extract from a given episode and person the number of asunits per > + second produced, and the number of clauses per asunits, for L2 and L1." > + (interactive "sepisodenumber: \nspersonid:") > + (setq interventionsl2 '()) > + (setq interventionsl1 '()) > + (setq xml (xml-parse-region (point-min) (point-max))) > + (setq results (car xml)) > + (setq episodes (xml-get-children results 'episode)) > + (setq asunitsl2 0.0000) > + (setq asunitsl1 0.0000) > + (setq clausesl1 0.0000) > + (setq errorsl1 0.0000) > + (setq clausesl2 0.0000) > + (setq errorsl2 0.0000) Are these local or global variables? If they're local, turn this list of `setq's into a `let'. If they're global, rename them to start with `transcribe-' and add a top-level `defvar' for each one. Also: > + (setq shifts) This should be (setq shifts nil). Emacs 25.1 no longer allows (setq shifts).