From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Date: Sun, 15 Mar 2015 22:35:03 -0300 Message-ID: References: <20150315082509.21193.18465@vcs.savannah.gnu.org> <55054CE9.6010702@dancol.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1426469723 19225 80.91.229.3 (16 Mar 2015 01:35:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 16 Mar 2015 01:35:23 +0000 (UTC) Cc: Daniel Colascione , emacs-devel , Tassilo Horn To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 16 02:35:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXJw0-0000GK-8Q for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 02:35:12 +0100 Original-Received: from localhost ([::1]:46587 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXJvz-0003uc-FA for ged-emacs-devel@m.gmane.org; Sun, 15 Mar 2015 21:35:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXJvv-0003rb-2l for emacs-devel@gnu.org; Sun, 15 Mar 2015 21:35:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXJvu-0007IE-5h for emacs-devel@gnu.org; Sun, 15 Mar 2015 21:35:07 -0400 Original-Received: from mail-lb0-x229.google.com ([2a00:1450:4010:c04::229]:35010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXJvs-0007C5-KT; Sun, 15 Mar 2015 21:35:04 -0400 Original-Received: by lbcgn8 with SMTP id gn8so11012947lbc.2; Sun, 15 Mar 2015 18:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=C0LgwfbwMWJX1pAzAvJuTzShTKqfTqkIDlERbmgteA0=; b=y188xdv/2boqgaMQvxEoQE/0eLj7LWOh0mP9i1tucfklQgeF+hmjrljeooPlMNxCnn 1DzFnrMrv+NmYG83wXs3OwZjZHK+Y0t7JHmHmH5WFJe6KmaM6vRj4IHUDQEmY2pA0FfP +I4wkgx4JsyGqaEN31KkUC3InAEmQqI+JOG9uO6bs6opxHEB99CqQGuWJDR8B1XSOynK a206Httbrtm9/cJ5MjPbmb53lyi+fVUiZc0Qf/Cr+ZlNailqzk0gwhAyuMt8SbB4yEjF Y3eWEeK/G1MRcCo4dm8nq+ZvtKz+RsbEIIE4GcSCfULaPS5JEUjT0I7jvR+/f4x44X+E 1nEA== X-Received: by 10.112.110.231 with SMTP id id7mr53081325lbb.28.1426469703838; Sun, 15 Mar 2015 18:35:03 -0700 (PDT) Original-Received: by 10.112.207.225 with HTTP; Sun, 15 Mar 2015 18:35:03 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: MSrcnbYyV3lwYYqjFy96rJncxHw X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183888 Archived-At: My initial reaction was the same as Drew, I was surprised at seing this implemented without previous discussion. However... I'm testing this change now and I like it! Of course there needs to be a way for macros do declare themselves non-special. But I think being special by default is a good choice. I also vote for enabling this by default. Disabling an unwanted feature is 100 times easier than discovering an unknown feature, for newbies and veterans alike. Finally, I'm positively surprised at how fast the update function is. I would have expected some lag, but haven't found any (even though I'm looking). 2015-03-15 16:15 GMT-03:00 Stefan Monnier : >> Is it really a good idea to highlight *all* macros? Many are meant to be >> used just like functions and have the same semantics. > > IMNSHO most of those are mistakes (should use compiler-macros instead). > >> Instead of updating a big macro regexp after load, there should be >> a `declare' attribute that would let specific macros (and functions) >> opt into being fontified specially. > > Maybe the other way around would be better: add a declaration that says > "this macro faithfully mimicks the behavior of a function". > >> As it is, I'm going to have to disable this functionality locally. > > I must admit I haven't tried it out yet, so I'm not sure if I'll like > the result. > > > Stefan >