From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: builds are getting slower? Date: Thu, 10 Dec 2015 08:14:30 +0000 Message-ID: References: <5668E655.3080109@cs.ucla.edu> <5669217A.1040509@cs.ucla.edu> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11401752cb2755052686cb59 X-Trace: ger.gmane.org 1449735282 32591 80.91.229.3 (10 Dec 2015 08:14:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Dec 2015 08:14:42 +0000 (UTC) Cc: Glenn Morris , emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 10 09:14:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a6wN7-0001CA-DA for ged-emacs-devel@m.gmane.org; Thu, 10 Dec 2015 09:14:41 +0100 Original-Received: from localhost ([::1]:39879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6wN6-0003kC-H4 for ged-emacs-devel@m.gmane.org; Thu, 10 Dec 2015 03:14:40 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6wN3-0003k3-Ij for emacs-devel@gnu.org; Thu, 10 Dec 2015 03:14:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6wN2-00080B-Go for emacs-devel@gnu.org; Thu, 10 Dec 2015 03:14:37 -0500 Original-Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:36476) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6wN0-0007zx-JP; Thu, 10 Dec 2015 03:14:34 -0500 Original-Received: by lfed137 with SMTP id d137so686171lfe.3; Thu, 10 Dec 2015 00:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=UKACMR1tssc4LHk5LBMRgL8Ff8Sk4/Yd1clJbK/HZfw=; b=l1xneKj16MYtt7HYuAdSLGGWCofaDYhfWlX/yb12NLQF0k0tC2XBEy+KvHoRxnfQ4L tOKYmizphhGS7/38pkhsmp0V94f10pQ1fJfOzdPYDMeY5F7N5NuhR/USSWkonIq5kWr6 u62wSDrHOU3M5+7o85Mri1X1cuQYn+3DMoo2O0FOkd3ieiY/AcRAEnCfRhoHi4A56lgF WqbkiI+ILYo6V97dnj6rxXiiyhz7JKwWDAprJP4OuO5dnbg0ITPpXjuEBMDHEigAqKoY 4bqaz5PyTatatK0AKoS21nxQFS4Urpe1VyH40WHfzHhZPv50h93Wt3CTCfeNJNKSWrKz owUw== X-Received: by 10.25.147.84 with SMTP id v81mr4528205lfd.119.1449735270112; Thu, 10 Dec 2015 00:14:30 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Thu, 10 Dec 2015 00:14:30 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Thu, 10 Dec 2015 00:14:30 -0800 (PST) In-Reply-To: <5669217A.1040509@cs.ucla.edu> X-Google-Sender-Auth: NHFj3AnXlqa26iJNA-zJ6LKLHTo X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196014 Archived-At: --001a11401752cb2755052686cb59 Content-Type: text/plain; charset=UTF-8 On 10 Dec 2015 6:53 am, "Paul Eggert" wrote: > There's a larger performance hit between 20151109 and 20151110. The log for that time period (0730 Pacific cutoff) is attached as log2.txt. Nothing jumps out, I'm afraid. > In one of my commis there I think I added (require 'map) to files.el, but I don't think the impact of that would be so noticeable. There's another commit there which could affect performance (it talks about not using XFASTINT, in a function that is used a bajillion times throughout core). It's this one by Eli. commit 86c19714b097aa477d339ed99ffb5136c755a046 Author: Eli Zaretskii AuthorDate: Mon Nov 9 10:31:45 2015 Commit: Eli Zaretskii CommitDate: Mon Nov 9 10:31:45 2015 Fix assertion violation in define-key * src/keymap.c (store_in_keymap): Don't use XFASTINT on non-character objects. Reported by Drew Adams and Juanma Barranquero . --001a11401752cb2755052686cb59 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 10 Dec 2015 6:53 am, "Paul Eggert" <eggert@cs.ucla.edu> wrote:
> There's a larger performance hit between 20151109 and 20151110.=C2= =A0 The log for that time period (0730 Pacific cutoff) is attached as log2.= txt.=C2=A0 Nothing jumps out, I'm afraid.
>

In one of my commis there I think I added (require 'map)= to files.el, but I don't think the impact of that would be so noticeab= le.

There's another commit there which could affect performa= nce (it talks about not using XFASTINT, in a function that is used a bajill= ion times throughout core). It's this one by Eli.

commit 86c19714b097aa477d339ed99ffb5136c755a046
Author:=C2=A0=C2=A0=C2=A0=C2=A0 Eli Zaretskii <eliz@gnu.org>
AuthorDate: Mon Nov 9 10:31:45 2015
Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Eli Zaretskii <eliz@gnu.org>
CommitDate: Mon Nov 9 10:31:45 2015

=C2=A0=C2=A0=C2=A0 Fix assertion violation in define-key

=C2=A0=C2=A0=C2=A0 * src/keymap.c (store_in_keymap): Don'= ;t use XFASTINT on non-character
=C2=A0=C2=A0=C2=A0 objects.=C2=A0 Reported by Drew Adams <drew.adams@oracle.com>
=C2=A0=C2=A0=C2=A0 and Juanma Barranquero <lekktu@gmail.com>.

--001a11401752cb2755052686cb59--