Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Stefan Monnier]

>     Move package-version-join to subr.el as version-join

Why do you need it in subr.el?


        Stefan

Re: [Emacs-diffs] scratch/organizing-package.el 830cd2a 3/5: Reorganize package.el and divide it with page-breaks and comments

[Stefan Monnier]

(nitpick-mode 1)

> +\f
> +;;; Customization options
>  ;;;###autoload

I'd expect an empty line after the ";;; Customization options" header.


        Stefan

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

I don't, and I can move it back if preferred. I just put it together with
the other version-* functions.
On Mar 30, 2015 2:12 AM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
>
> >     Move package-version-join to subr.el as version-join
>
> Why do you need it in subr.el?
>
>
>         Stefan

[-- Attachment #2: Type: text/html, Size: 461 bytes --]

Re: [Emacs-diffs] scratch/organizing-package.el 830cd2a 3/5: Reorganize package.el and divide it with page-breaks and comments

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Sure. 👌
(nitpick-mode 1)

> +
> +;;; Customization options
>  ;;;###autoload

I'd expect an empty line after the ";;; Customization options" header.


        Stefan

[-- Attachment #2: Type: text/html, Size: 389 bytes --]

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Stefan Monnier]

> I don't, and I can move it back if preferred. I just put it together with
> the other version-* functions.

The others are in subr.el because the hordes were clamoring for ways to
test versions numbers instead of testing feature presence.

I understand that placing version-join next to it would be logical, but
if it's only used by package.el, then I think it can just as well stay
there.


        Stefan

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Artur Malabarba]

Sure, no problem.
Since nobody replied negatively to the other thread, is it ok if I
clean up the commits and merge to master? (keeping `version-join' in
package.el).

2015-03-30 15:02 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> I don't, and I can move it back if preferred. I just put it together with
>> the other version-* functions.
>
> The others are in subr.el because the hordes were clamoring for ways to
> test versions numbers instead of testing feature presence.
>
> I understand that placing version-join next to it would be logical, but
> if it's only used by package.el, then I think it can just as well stay
> there.
>
>
>         Stefan

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Stefan Monnier]

> Since nobody replied negatively to the other thread, is it ok if I
> clean up the commits and merge to master? (keeping `version-join' in
> package.el).

I don't object: I generally don't like such moving around since it makes
subsequent history-digging harder, but if it increases your motivation
enough to go and improve the package, I guess it's a good tradeoff.


        Stefan

Re: [Emacs-diffs] scratch/organizing-package.el 3d2409a 1/5: Move package-version-join to subr.el as version-join

[Artur Malabarba]

2015-03-30 22:03 GMT+01:00 Stefan Monnier <monnier@iro.umontreal.ca>:
>> Since nobody replied negatively to the other thread, is it ok if I
>> clean up the commits and merge to master? (keeping `version-join' in
>> package.el).
>
> I don't object: I generally don't like such moving around since it makes
> subsequent history-digging harder, but if it increases your motivation
> enough to go and improve the package, I guess it's a good tradeoff.

It has motivated me enough to implement async refreshing. :-)