From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Thu, 13 Aug 2015 19:13:36 +0100 Message-ID: References: <87si7rjqmp.fsf@newcastle.ac.uk> <87fv3rjogj.fsf@newcastle.ac.uk> <87fv3po7ss.fsf@russet.org.uk> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1439489655 32024 80.91.229.3 (13 Aug 2015 18:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Aug 2015 18:14:15 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 13 20:14:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPx0n-00020x-0B for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2015 20:13:57 +0200 Original-Received: from localhost ([::1]:43720 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPx0l-0005et-P0 for ged-emacs-devel@m.gmane.org; Thu, 13 Aug 2015 14:13:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPx0Y-0005dp-IZ for emacs-devel@gnu.org; Thu, 13 Aug 2015 14:13:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPx0U-0001Yn-1S for emacs-devel@gnu.org; Thu, 13 Aug 2015 14:13:42 -0400 Original-Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:35525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPx0T-0001YU-Po for emacs-devel@gnu.org; Thu, 13 Aug 2015 14:13:37 -0400 Original-Received: by lahi9 with SMTP id i9so30587127lah.2 for ; Thu, 13 Aug 2015 11:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=jM5Bi8VVIlGT/FEviVH1TdvXynYwo0qqvDU58EC65WA=; b=a3HM7Rv/ncYO+jdt3zY6M+iGL+UbQrzY6FGx80GyYi0goMdSUNffPzNaKoLPbD+Bhl 4I00PONcxKYnT7eJ2xj0OoVjTSAaZtjk+zDc0PTNYGLqksshMYzeVO7Yg9jACkkSP7M5 089MGW4CzapK4DnT4hTpspl/a5uePmkYXpiwNmKwTYBxiBU1yLBNuGIlrMKBDD0gme31 IrxqOZvkWpsjoih4QscAHV2RorxIrIE91ixZa8Pw+oZ2MQWqU2cgTO06B6IflySav6uy 3e7M5s04fUx4UDeayebNhY1hYo+NOCa+y8/0OLHIwngW4ATUTWL3Z1dIA3q+Twmlb+fE d4Aw== X-Received: by 10.152.180.161 with SMTP id dp1mr19677464lac.21.1439489616110; Thu, 13 Aug 2015 11:13:36 -0700 (PDT) Original-Received: by 10.25.134.139 with HTTP; Thu, 13 Aug 2015 11:13:36 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: rya_Ge9YpqyJ9unwUTg0YpiTqEI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188780 Archived-At: > Sounds good to me. A similar change is probably needed somewhere in > elpa.git's admin/*.el. I just looked into the archive--metadata function in elpa/admin/archive-contents.el. Looks like it would benefit from calling package-buffer-info instead of replicating the functionality. The only obstacle I see for that is the special treatment it gives to the org package: (or (lm-header "package-version") (lm-header "version") (unless (equal pkg "org") (error "Missing `version' header"))) Is this still necessary?