From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Adding a few more finder keywords Date: Mon, 8 Jun 2015 17:15:42 +0100 Message-ID: References: <87sia2l04r.fsf@gmail.com> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1433780163 950 80.91.229.3 (8 Jun 2015 16:16:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Jun 2015 16:16:03 +0000 (UTC) Cc: emacs-devel To: Oleh Krehel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 08 18:15:59 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z1ziK-00087Y-V2 for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 18:15:53 +0200 Original-Received: from localhost ([::1]:59059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1ziJ-00029o-Vj for ged-emacs-devel@m.gmane.org; Mon, 08 Jun 2015 12:15:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1ziD-00029e-0R for emacs-devel@gnu.org; Mon, 08 Jun 2015 12:15:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z1ziB-0002j6-LH for emacs-devel@gnu.org; Mon, 08 Jun 2015 12:15:44 -0400 Original-Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:33189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z1ziB-0002iZ-E5 for emacs-devel@gnu.org; Mon, 08 Jun 2015 12:15:43 -0400 Original-Received: by lbcue7 with SMTP id ue7so84072195lbc.0 for ; Mon, 08 Jun 2015 09:15:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=qNduMKxaqY+CK+8U+MZEyssn7TEJ8C1Ty4NcdV0t+Ck=; b=eZI6tJBwUt442T/F5TcQWcqbrJoEDWBczM5+gZcsHSIZQhGyqKQzQ2Vvyi29VVCkB9 HZyodoVVIRU819piIRUTo1GvfiFLI1mA1cx4atO4oSi7mvz4GM1jMtOITxVqh2hbkqEP 1B79qza6w8NqaF7O26tjI7UTRZSREIdRoewlZPmi9vo7VB0iwh6iwyIzznFDn6S9SFr0 K99jnLRRrbaszNcfscLGVik8tL8xkgiSzhVikU8uO0eZwwta7qeuGPEMc7K+TGplImEO EIFhFisZpyehuXe7HzdIW4kHFoZvNou1/A2OLZXvwD2XS7glIqzZaavuumMAhhpX3ZWH 0lvg== X-Received: by 10.152.203.233 with SMTP id kt9mr17766236lac.21.1433780142688; Mon, 08 Jun 2015 09:15:42 -0700 (PDT) Original-Received: by 10.25.214.133 with HTTP; Mon, 8 Jun 2015 09:15:42 -0700 (PDT) In-Reply-To: <87sia2l04r.fsf@gmail.com> X-Google-Sender-Auth: G80UVDLNAbTJzyQdlof-k2dWZUA X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187103 Archived-At: 2015-06-08 15:56 GMT+01:00 Oleh Krehel : > I've just added `checkdoc-package-keywords' that checks if the current > file's keywords are in `finder-known-keywords'. It's possible to make > `checkdoc-current-buffer' call `checkdoc-package-keywords' > automatically. I didn't make this the default, since > `finder-known-keywords' still doesn't contain such common keywords as > "org", "completion", "git" etc. > > What remains to do now, is to extend `finder-known-keywords', and > possibly make `checkdoc-package-keywords-flag' default to t. Besides extending `finder-known-keywords', I think checkdoc should offer a list variable like `checkdoc-keywords-to-ignore-warnings', which the developer can use in his personal configs to explicitly prevent some warnings. Once both are done I would personally be fine with defaulting the flag to `t`.