From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Kelly Dean <kelly@prtime.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Short patch for review
Date: Thu, 19 Feb 2015 11:07:04 +0000 [thread overview]
Message-ID: <CAAdUY-KN523wAyPnDvdoFMfWMwT6XqHUTa56x=o0A2zM05xH2g@mail.gmail.com> (raw)
In-Reply-To: <83r3tm4fia.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
According to its docstring, it's for cases where the user does something
wrong. Calling a command on the wrong buffer, providing invalid input,
things like that.
We also have a few instances where it's used to abort commands when the
user answers "No" to a query. I'm not 100% sure those instances qualify,
but it's certainly way better than throwing actual errors.
On Feb 19, 2015 5:49 AM, "Eli Zaretskii" <eliz@gnu.org> wrote:
> > Date: Wed, 18 Feb 2015 19:17:52 -0200
> > From: Artur Malabarba <bruce.connor.am@gmail.com>
> > Cc: Kelly Dean <kelly@prtime.org>
> >
> > Hi all, Kelly sent me a patch for changing a couple of `error'
> > instances into `user-error'.
> > It looks ok to me, but I'd appreciate if someone could confirm that
> > it's alright.
>
> Do we have guidelines for which errors should be 'user-error'?
>
[-- Attachment #2: Type: text/html, Size: 1284 bytes --]
next prev parent reply other threads:[~2015-02-19 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 21:17 Short patch for review Artur Malabarba
2015-02-18 22:51 ` Stefan Monnier
2015-02-19 5:49 ` Eli Zaretskii
2015-02-19 10:30 ` Kelly Dean
2015-02-19 11:07 ` Artur Malabarba [this message]
2015-02-19 11:18 ` Eli Zaretskii
2015-02-19 13:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAdUY-KN523wAyPnDvdoFMfWMwT6XqHUTa56x=o0A2zM05xH2g@mail.gmail.com' \
--to=bruce.connor.am@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kelly@prtime.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).