From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 188f657: Fix false negatives in tex--prettify-symbols-compose-p. Date: Wed, 30 Sep 2015 11:08:52 +0100 Message-ID: References: <20150925210512.18505.12538@vcs.savannah.gnu.org> <8737xxjtkq.fsf@gnu.org> <87wpv8mgeh.fsf@gnu.org> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1443680869 28354 80.91.229.3 (1 Oct 2015 06:27:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 06:27:49 +0000 (UTC) To: Artur Malabarba , Davis Herring , emacs-devel , Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 01 08:27:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhXLI-0004iw-8I for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 08:27:48 +0200 Original-Received: from localhost ([::1]:38520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhXLH-0004Qc-L8 for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 02:27:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhEJn-0004ej-Gh for emacs-devel@gnu.org; Wed, 30 Sep 2015 06:09:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhEJm-0004CK-MW for emacs-devel@gnu.org; Wed, 30 Sep 2015 06:08:59 -0400 Original-Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:34967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhEJh-0004Ab-8e; Wed, 30 Sep 2015 06:08:53 -0400 Original-Received: by laer8 with SMTP id r8so39775748lae.2; Wed, 30 Sep 2015 03:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=RGceHE3mTNCKSO7OzsPB6pnQw7/uXZmAFAxB+bTE+xQ=; b=YIK54owuh3gZNNzq4eK+xE5aQzKHthAHJcMYQA+uZdw3s3N28Roohe6D2FIqWmcgnK kAT0Jk2uyZwBIeiZZa3KXruotFbY3rZo2fJO3ZVtUnbcenk94q/tp9ezUGorCUJwRnY/ HYNL4sfp93lXDO2d4aXwjTOVwZjNXfxezzOb0rTZKo+lH/zz6sBAFKXGRg9pg4Uxig8n olGJAY3IMFZSOWStl3EWUW/V7NOQ5uuJyExoVo3FX4YXF469M0BSFc55foP9uRhLMLRh cymgWcJ98f9e1nMkdhoXB98TxCnaOFc5jcd29tr0We4K/0vhDZOdAe5WGmRL11LeYyN1 JBFA== X-Received: by 10.152.30.105 with SMTP id r9mr844443lah.95.1443607732165; Wed, 30 Sep 2015 03:08:52 -0700 (PDT) Original-Received: by 10.25.27.78 with HTTP; Wed, 30 Sep 2015 03:08:52 -0700 (PDT) In-Reply-To: <87wpv8mgeh.fsf@gnu.org> X-Google-Sender-Auth: jhV8HZiQS4yRx81o3qBQzKmrAuA X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190511 Archived-At: 2015-09-30 9:59 GMT+01:00 Tassilo Horn : > Artur Malabarba writes: > >>> Could mimicking (better: merging with) the approach of reveal-mode >>> help? >> >> Now that Tassilo seems to have it working, I don't think it's worth >> mimicking something else. However, if the feature can be simplified >> by merging with reveal mode then that would surely be nice. > > I didn't get Davis email until now He accidentally sent it only to me (instead of to the list). > (and it seems that mails from or to > emacs-devel are somehow deferred; do you have such issues, too?) I have noticed that when I try to "reply-all" one of your emails your address is never included in the To: field (I added it manually now). The list address does get included, though, so you probably receive the emails anyway. > We can't use that because `reveal-mode' is > specialized for revealing overlays whereas `prettify-symbols-mode' uses > text properties. Alright. I tested the code now and it works well. My only suggestion would be to change this: (< (point) (car prettify-symbols--current-symbol-bounds)) to this: (<= (point) (car prettify-symbols--current-symbol-bounds)) But I guess that's more of a personal preference. Either way I think it looks good to merge. Cheers