From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Apparent regression on the undo command Date: Sat, 21 Nov 2015 11:18:00 +0000 Message-ID: References: <87bnarsdfy.fsf@russet.org.uk> <871tbm9v83.fsf@russet.org.uk> <87wpte6slz.fsf@russet.org.uk> <87io4xpio3.fsf@red-bean.com> <87y4drllg8.fsf@russet.org.uk> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c3b13e17fbbe05250b25ac X-Trace: ger.gmane.org 1448104708 27417 80.91.229.3 (21 Nov 2015 11:18:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Nov 2015 11:18:28 +0000 (UTC) Cc: Karl Fogel , emacs-devel To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 21 12:18:23 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a06BS-0005G6-2q for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2015 12:18:22 +0100 Original-Received: from localhost ([::1]:51907 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a06BR-0006OZ-D4 for ged-emacs-devel@m.gmane.org; Sat, 21 Nov 2015 06:18:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a06BC-0006OU-Su for emacs-devel@gnu.org; Sat, 21 Nov 2015 06:18:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a06B8-0000Ud-FC for emacs-devel@gnu.org; Sat, 21 Nov 2015 06:18:06 -0500 Original-Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:36504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a06B8-0000UZ-3T for emacs-devel@gnu.org; Sat, 21 Nov 2015 06:18:02 -0500 Original-Received: by lbblt2 with SMTP id lt2so74915916lbb.3 for ; Sat, 21 Nov 2015 03:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=kA88++eQmuxPRvZbdfDClyOwu006vkMinC1IE7Kh+CA=; b=CtcO847Sui6dydDmgtBI6tDPNPmw090C6CYUl/QSM9IfyFdP6EAnAIDXSeVLRX5381 SV2H+aV4nAvO2zYTeYlIMUT5un615X4if3MSPse3nhVbJ5VT7oR5pjq7vO/cH/0W7u5D k/C6FbSFUfpzY782i9JekDJ36dxJ8jroo/X4qn1PayyFQacvlKlDuQf7NNjopf7TqcDY ChEErG1bHcfEcL5VP/NyVK731sj02oHOJP5wugS26O06mRk59/5RjuDH63ZISzWhRdj/ 1sxtWJrCjcNXJlSvmRWt0pnz9DOttp/13X3n8/k/rzbnnRVlduKUmtpJe+//zbDQkvL9 6oOA== X-Received: by 10.112.13.66 with SMTP id f2mr403402lbc.79.1448104680747; Sat, 21 Nov 2015 03:18:00 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sat, 21 Nov 2015 03:18:00 -0800 (PST) In-Reply-To: <87y4drllg8.fsf@russet.org.uk> X-Google-Sender-Auth: v_b5zLR42axgMz5CaFYh7cAhhZ4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194945 Archived-At: --001a11c3b13e17fbbe05250b25ac Content-Type: text/plain; charset=UTF-8 I can't speak for the code, but I just tested your fix and looks like it works. Thanks Phil. 2015-11-21 10:02 GMT+00:00 Phillip Lord : > > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. > > Phil > > > Artur Malabarba writes: > > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" > wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had a > nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord : > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in batch > >> >either because *scratch* hasn't been initialized, or undo appears to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> > --001a11c3b13e17fbbe05250b25ac Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I can't speak for the code, but I just tested your fix= and looks like it works.

Thanks Phil.

2015-11-21 10:02 GMT+00= :00 Phillip Lord <phillip.lord@russet.org.uk>:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
I have a possible fix for this now, currently on the
branch fix/undo-point-in-wrong-place. I waiting for some other feedback
on my code before I squash and merge it, but if you have the chance it
would be good to know if it works.

Phil


Artur Malabarba <bruce.conn= or.am@gmail.com> writes:

> No problem Phil.
> Thanks for looking into this.
> On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote:<= br> >
>>
>> It is my commit after all. I will work on it as soon as I can. Had= a nasty
>> cold for the last few days.
>>
>> Phil
>> ________________________________________
>> From: emacs-devel-bounces+phillip.lord=3Dnewcastle.ac.uk@gnu.org
>> [emacs-devel-bounces+phillip.lord=3Dnewcastle.ac.uk@gnu.org] on behalf of
>> Karl Fogel [kfogel@red-bean= .com]
>> Sent: 20 November 2015 01:24
>> To: Phillip Lord
>> Cc: Artur Malabarba; emacs-devel
>> Subject: Re: Apparent regression on the undo command
>>
>> phillip.lord@russet.= org.uk (Phillip Lord) writes:
>> >Artur Malabarba <bruce.connor.am@gmail.com> writes:
>> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>:
>> >>> I'll try and see if I can automate the problem an= d
>> >>> run a bisect.
>> >>
>> >> The following works for me. When called on the *scratch* = buffer it
>> >> returns non-nil if the problem occurs.
>> >>
>> >> (progn
>> >>=C2=A0 =C2=A0(kmacro-call-macro nil nil nil [134217788 11 = 14 14 11 67108911])
>> >>=C2=A0 =C2=A0(equal (point-min) (point)))
>> >>
>> >> That macro simply calls M-< C-k C-n C-n C-k C-/
>> >
>> >
>> >I tried various combinations -- works interactively but fails = in batch
>> >either because *scratch* hasn't been initialized, or undo = appears to
>> >work wrongly.
>> >
>> >No worries, it's easy enough to test by hand, and am doing= so.
>>
>> Any luck?=C2=A0 FWIW I'm noticing the bug too, in emacs-25 bra= nch built from
>> commit c210b8b128c.
>>
>> Best regards,
>> -Karl
>>
>>

--001a11c3b13e17fbbe05250b25ac--