From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Should we have a commit size guideline? (was: builds are getting slower?) Date: Tue, 15 Dec 2015 13:48:28 +0000 Message-ID: Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1450187333 6790 80.91.229.3 (15 Dec 2015 13:48:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Dec 2015 13:48:53 +0000 (UTC) Cc: emacs-devel To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 15 14:48:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a8py4-0000Ct-CU for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 14:48:40 +0100 Original-Received: from localhost ([::1]:36945 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8py3-0008QX-U6 for ged-emacs-devel@m.gmane.org; Tue, 15 Dec 2015 08:48:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8py0-0008QP-1w for emacs-devel@gnu.org; Tue, 15 Dec 2015 08:48:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8pxu-0004ES-I1 for emacs-devel@gnu.org; Tue, 15 Dec 2015 08:48:36 -0500 Original-Received: from mail-lf0-x22d.google.com ([2a00:1450:4010:c07::22d]:33796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8pxt-0004E7-5k; Tue, 15 Dec 2015 08:48:29 -0500 Original-Received: by mail-lf0-x22d.google.com with SMTP id y184so6835970lfc.1; Tue, 15 Dec 2015 05:48:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:date:message-id:subject:from:to:cc :content-type; bh=pl0QrTj1ICkphLe0BcjPvB+S8u95UvtRfjOgsauIzhg=; b=tT/OsSi3I/LvkURf8c8U1Y06wAkU3D/mCDfQ5qQchIylAIQ5N2Bwme1op4CZVQgwAb 2Iiwqy9IlJjAPiHJ75iuZoGRhJkGOJ0cWrpH129+q3n7yr0sleugGkLqYTyg9bs8O6Z1 1/wibNw4CZpuOzp+VjNCECWrEWX143WCUyhbY9qO2VpgGlEzONnla3OGeA8Svhla+9FE WKyJOtf30gY3zfX7Smcs9M1apV8NroK7nzqqSpQR/9zT2Br7QcXJmiCTYo6IbURXi+fN ORF9caoTka2fCSTM3qhqbuoMPFViTpv8R6rFE6SLitlnlFsu3qS1/H4ms+q0lsUZR9tm 4NeQ== X-Received: by 10.25.155.136 with SMTP id d130mr11050766lfe.54.1450187308260; Tue, 15 Dec 2015 05:48:28 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Tue, 15 Dec 2015 05:48:28 -0800 (PST) X-Google-Sender-Auth: at-6R-ocP_BFeyFOM44yk2TArnI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196301 Archived-At: 2015-12-15 12:49 GMT+00:00 David Kastrup : > [Regarding commit 2e84888] > > This is a very, very large commit. It should have been split into > multiple commits addressing separate issues. When commiting changes, I usually group them into the smallest possible commits while still leaving everything in a consistent state (i.e., not defining a function that's only used in later commits, not changing a function without making the necessary changes in other places that call this function). I find that this helps with both git-bisect and git-revert. If we have a different policy (maybe we should) I'm happy to adhere. Cheers, Artur