From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Organizing package.el a bit Date: Sun, 29 Mar 2015 13:56:33 +0100 Message-ID: References: <86384odvja.fsf@dod.no> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1427633802 25598 80.91.229.3 (29 Mar 2015 12:56:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Mar 2015 12:56:42 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 29 14:56:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YcClb-0006jz-QV for ged-emacs-devel@m.gmane.org; Sun, 29 Mar 2015 14:56:40 +0200 Original-Received: from localhost ([::1]:56993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcClb-0001hC-65 for ged-emacs-devel@m.gmane.org; Sun, 29 Mar 2015 08:56:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcClX-0001d3-Tl for emacs-devel@gnu.org; Sun, 29 Mar 2015 08:56:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcClW-0005GL-PK for emacs-devel@gnu.org; Sun, 29 Mar 2015 08:56:35 -0400 Original-Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:33141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcClW-0005Fs-DV for emacs-devel@gnu.org; Sun, 29 Mar 2015 08:56:34 -0400 Original-Received: by lbcmq2 with SMTP id mq2so90618706lbc.0 for ; Sun, 29 Mar 2015 05:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=RfVlP1kYdKxnCvSFJW8UY7GL1lhlBqZpqSPZuI4WNoM=; b=w0S/6KuGzQzQDoWuelTsO1QXVmIEk4pOWFhmXGNdxX3UMtuzzpQ9S3Mse+4g+tHkJ5 Xw6+EQ7l8asRo3VxlIuCpXsXP/DP0A27NQuR9qQCynRTmJ4KouNvbU+JN1aCoQNX7/Ik tkdsJQI23QuLS1Ng8wA80W95yIbhSohZHoVZjIpl0DcLC2Uih5rxaWyrRYFsyfDJVbBJ dBbOHOM5z51OaaZ8WEze1CKhxT9sqJYJCV/kIXw3FXdo9roIovjbH19hWFuIZ3OLWnJc iYAU1T43tCbQv01fFRf25Nyzd+G4zjBOLpR4Oyf6utMMjRrIBfKwU7bap7BxSLrV4Tbj dMbw== X-Received: by 10.152.121.33 with SMTP id lh1mr24981984lab.86.1427633793501; Sun, 29 Mar 2015 05:56:33 -0700 (PDT) Original-Received: by 10.112.207.225 with HTTP; Sun, 29 Mar 2015 05:56:33 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: SQTkO8E26EidPZ0ur2gyXb83SHE X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184512 Archived-At: Nevermind, the test fails on master for me as well. 2015-03-29 12:06 GMT+01:00 Artur Malabarba : > I just pushed a proposal for this (using page-breaks, not separate > files) into scratch/organizing-package.el, but if people don't want me > to do the reorganization, I'll just delete the branch and forget about > it. > > The branch is just a bunch of moving around. The only code change is > on the first commit, it moves `package-version-join' to subr.el (with > the other version-* functions) under the name `version-join'. > > Oddly, it's causing the test `file-notify-test03-autorevert-remote' to fail. > > 2015-03-29 10:04 GMT+01:00 Steinar Bang : >>>>>>> Artur Malabarba : >> >>> I'd like to know whether it's ok to split it into two files, >>> package.el and package-menu.el? >> >>> The distinction is very logic, there's a ton of stuff that goes on in >>> package.el which doesn't make any use of the package-menu. >>> The only downside of this refactoring would be to mess up things like >>> `git-blame`, and that's why I'm askinghere. >> >> If you do >> cp package.el package-menu.el >> git add package-menu.el >> git commit -m "Copying verbatim to preserve history" >> >> before you start working, and then do your changes by removing stuff >> from package-menu.el (and package.el) and not move things around >> otherwise, then git-blame should show the correct history. >> >>