unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>,
	emacs-devel <emacs-devel@gnu.org>
Cc: emacs-elpa-diffs@gnu.org
Subject: Re: [elpa] master 5640cd0 04/12: el-search: some comment changes
Date: Mon, 12 Oct 2015 00:29:57 +0100	[thread overview]
Message-ID: <CAAdUY-JJyTjhPUhdTQWiAgfZzxpZJDAw4xo9mUL005SKqFY4iQ@mail.gmail.com> (raw)
In-Reply-To: <E1ZlDwV-0000c5-Vx@vcs.savannah.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

On 11 Oct 2015 11:33 am, "Michael Heerdegen" <michael_heerdegen@web.de>
wrote:
> +  ;; FIXME: an interesting alternative would be to really integrate it
> +  ;; with Isearch, using `isearch-search-fun-function'.
> +  ;; Alas, this is not trivial if we want to transfer our optimizations.
>    (interactive)
>    (el-search-pattern
>     (el-search--read-pattern

Can you explain why? I've been thinking of making some refactorings to
isearch (after the feature freeze) and I could try to extend
isearch-search-fun-function to cover your use case if it's not too hard.

Best,
Artur

[-- Attachment #2: Type: text/html, Size: 784 bytes --]

       reply	other threads:[~2015-10-11 23:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151011103325.2269.2052@vcs.savannah.gnu.org>
     [not found] ` <E1ZlDwV-0000c5-Vx@vcs.savannah.gnu.org>
2015-10-11 23:29   ` Artur Malabarba [this message]
2015-10-12  9:46     ` [elpa] master 5640cd0 04/12: el-search: some comment changes Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-JJyTjhPUhdTQWiAgfZzxpZJDAw4xo9mUL005SKqFY4iQ@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-elpa-diffs@gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).