From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Wed, 12 Aug 2015 21:10:37 +0100 Message-ID: References: <87si7rjqmp.fsf@newcastle.ac.uk> <87fv3rjogj.fsf@newcastle.ac.uk> <87fv3po7ss.fsf@russet.org.uk> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1439410249 6272 80.91.229.3 (12 Aug 2015 20:10:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Aug 2015 20:10:49 +0000 (UTC) Cc: Kaushal , Emacs developers , Phillip Lord To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 12 22:10:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZPcMJ-0003bp-MF for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 22:10:47 +0200 Original-Received: from localhost ([::1]:40042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPcMI-0002Pt-TK for ged-emacs-devel@m.gmane.org; Wed, 12 Aug 2015 16:10:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPcMB-0002Po-FL for emacs-devel@gnu.org; Wed, 12 Aug 2015 16:10:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPcMA-0000rd-Ju for emacs-devel@gnu.org; Wed, 12 Aug 2015 16:10:39 -0400 Original-Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]:35270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPcMA-0000rB-7n for emacs-devel@gnu.org; Wed, 12 Aug 2015 16:10:38 -0400 Original-Received: by lbcbn3 with SMTP id bn3so15782735lbc.2 for ; Wed, 12 Aug 2015 13:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=rdBxCiPKuNCN/0k7j/tE5ZYELrscuvAXvOCaSFvQlHA=; b=C45M2xHOaWjOB5E8j91RHCtG60m8AWFoR/oHpMPEYv5VMnxi90gGUHojuJ2wrEW0TA z2RzGIvc5CBdHY4+FnoCT2EDHvM5JLXPSciTj8eRWuJl4neJwH1hwimkl7KQ25oQyV/6 7FpxyiYAg0DrwnHVmiSJ+w5AfNSOlgBvT7ahhrHjlxMX6sqcXQwKRlhz87fDk63W8c4h PlfYZA77WCMENYyZA1+BjkIK2Gbl3mGq1wf9s+ZIltORczfpPdpBYRaIdffFfffel92M 1up1tzSLnTohIg9A6qmKTQVJwR9wxfF1SncEsw1JVWdcAj0cPCgoKj0rKAXwDfqwT2p+ zNsw== X-Received: by 10.112.138.199 with SMTP id qs7mr33008686lbb.21.1439410237472; Wed, 12 Aug 2015 13:10:37 -0700 (PDT) Original-Received: by 10.25.134.139 with HTTP; Wed, 12 Aug 2015 13:10:37 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: 0NubfCH4MwptB1dcYJnET1lKZGc X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188765 Archived-At: 2015-08-12 18:18 GMT+01:00 Stefan Monnier : >> - (let* ((requires-str (lm-header "package-requires")) >> + (let* ((requires-str (when-let ((reqs (lm-header-multiline >> "package-requires"))) >> + (apply #'concat reqs))) > > Sounds good to me. A similar change is probably needed somewhere in > elpa.git's admin/*.el. > > I do wonder why lm-header doesn't just automatically handle > multiline headers. Backwards compatibility? We could have a new function for that, though I can't think of a short name.