unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: What to do for faster `remove-duplicates'?
Date: Wed, 6 May 2015 19:31:47 +0100	[thread overview]
Message-ID: <CAAdUY-+z_5W6DGV2gW8a+aLkDm+sOkz+RR5O4ZqCunsjExThRQ@mail.gmail.com> (raw)
In-Reply-To: <87bnhxeh4j.fsf@gmail.com>

>> Looks good, please install.
>
> Not so good as now it is no more destructive for a seq > 100.

Just pushed the following:

modified   lisp/subr.el
@@ -424,12 +424,12 @@ one is kept."
           (unless (gethash elt hash)
             (puthash elt elt hash)
             (push elt res)))
-        (nreverse res))
+        (setcdr list (cdr (nreverse res))))
     (let ((tail list))
       (while tail
         (setcdr tail (delete (car tail) (cdr tail)))
-        (setq tail (cdr tail))))
-    list))
+        (setq tail (cdr tail)))))
+  list)



  parent reply	other threads:[~2015-05-06 18:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06  7:33 What to do for faster `remove-duplicates'? Oleh Krehel
2015-05-06 12:59 ` Stefan Monnier
2015-05-06 13:30   ` Oleh Krehel
2015-05-06 13:50     ` Stefan Monnier
2015-05-06 13:51       ` Oleh Krehel
2015-05-06 17:43       ` Thierry Volpiatto
2015-05-06 17:54         ` Oleh Krehel
2015-05-06 18:31         ` Artur Malabarba [this message]
2015-05-06 18:33           ` Artur Malabarba
2015-05-06 18:41             ` Oleh Krehel
2015-05-06 19:24               ` Artur Malabarba
2015-05-06 19:32                 ` Oleh Krehel
2015-05-06 21:22                   ` Artur Malabarba
2015-05-06 18:48           ` Thierry Volpiatto
2015-05-06 20:54             ` Stefan Monnier
2015-05-06 20:54           ` Stefan Monnier
2015-05-06 21:18             ` Artur Malabarba
2015-05-06 14:04     ` Artur Malabarba
2015-05-06 14:13       ` Oleh Krehel
2015-05-06 14:49         ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAdUY-+z_5W6DGV2gW8a+aLkDm+sOkz+RR5O4ZqCunsjExThRQ@mail.gmail.com \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).