From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Organizing package.el a bit Date: Sun, 29 Mar 2015 12:06:26 +0100 Message-ID: References: <86384odvja.fsf@dod.no> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1427627202 25909 80.91.229.3 (29 Mar 2015 11:06:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Mar 2015 11:06:42 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 29 13:06:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YcB38-0006XF-Ql for ged-emacs-devel@m.gmane.org; Sun, 29 Mar 2015 13:06:39 +0200 Original-Received: from localhost ([::1]:56646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcB32-00037t-Hx for ged-emacs-devel@m.gmane.org; Sun, 29 Mar 2015 07:06:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcB2z-00034N-2A for emacs-devel@gnu.org; Sun, 29 Mar 2015 07:06:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YcB2y-0000Wd-4B for emacs-devel@gnu.org; Sun, 29 Mar 2015 07:06:29 -0400 Original-Received: from mail-lb0-x233.google.com ([2a00:1450:4010:c04::233]:35647) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YcB2x-0000WS-SV for emacs-devel@gnu.org; Sun, 29 Mar 2015 07:06:28 -0400 Original-Received: by lbdc10 with SMTP id c10so35659205lbd.2 for ; Sun, 29 Mar 2015 04:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=k6V30V60HQuF3NBcc7vYceW5m8nNivBeRgfkJrTxSdU=; b=BfzF6UlStGLmsEt64ecPkBhg27oOc3/koVpYKoF2P4l+/KEDrMCpEJ2RzUisQXP/xs VwFA/JCwoHwlQHpuHzsW2LDWIE0K80xByYVnCuKS/NNuQF9B6qUQdiIuZ8Hy80QNorgz FZtdyTN4OtDLsTJYd9epO3XQpLzIpUW/WqKUY1AK6rOjnGlDFcWgx/LGMCg+M099Nqp5 CCkda+QCtqVwWU0fBTF3kLzn/Q+KmLvzj0HTai0E2nT/+BFqQgXjJyUdk2d1/cMbyu69 WAq2ODAbJfT5Dw18Mvsq5UuO0IQcO8mV+RYfohnkZAb94CdU4cuERg6ors1rPe3RWg2L b3fA== X-Received: by 10.153.5.37 with SMTP id cj5mr25061404lad.14.1427627186459; Sun, 29 Mar 2015 04:06:26 -0700 (PDT) Original-Received: by 10.112.207.225 with HTTP; Sun, 29 Mar 2015 04:06:26 -0700 (PDT) In-Reply-To: <86384odvja.fsf@dod.no> X-Google-Sender-Auth: oJEDsvSB4ray7sttKGsbop5YHWs X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:184510 Archived-At: I just pushed a proposal for this (using page-breaks, not separate files) into scratch/organizing-package.el, but if people don't want me to do the reorganization, I'll just delete the branch and forget about it. The branch is just a bunch of moving around. The only code change is on the first commit, it moves `package-version-join' to subr.el (with the other version-* functions) under the name `version-join'. Oddly, it's causing the test `file-notify-test03-autorevert-remote' to fail. 2015-03-29 10:04 GMT+01:00 Steinar Bang : >>>>>> Artur Malabarba : > >> I'd like to know whether it's ok to split it into two files, >> package.el and package-menu.el? > >> The distinction is very logic, there's a ton of stuff that goes on in >> package.el which doesn't make any use of the package-menu. >> The only downside of this refactoring would be to mess up things like >> `git-blame`, and that's why I'm askinghere. > > If you do > cp package.el package-menu.el > git add package-menu.el > git commit -m "Copying verbatim to preserve history" > > before you start working, and then do your changes by removing stuff > from package-menu.el (and package.el) and not move things around > otherwise, then git-blame should show the correct history. > >