unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Artur Malabarba <bruce.connor.am@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Organizing package.el a bit
Date: Sun, 29 Mar 2015 12:06:26 +0100	[thread overview]
Message-ID: <CAAdUY-+TDrL=5ts9zxy23OfSnL=-dSYt7gGvbQkgDbfQ25kS0w@mail.gmail.com> (raw)
In-Reply-To: <86384odvja.fsf@dod.no>

I just pushed a proposal for this (using page-breaks, not separate
files) into scratch/organizing-package.el, but if people don't want me
to do the reorganization, I'll just delete the branch and forget about
it.

The branch is just a bunch of moving around. The only code change is
on the first commit, it moves `package-version-join' to subr.el (with
the other version-* functions) under the name `version-join'.

Oddly, it's causing the test `file-notify-test03-autorevert-remote' to fail.

2015-03-29 10:04 GMT+01:00 Steinar Bang <sb@dod.no>:
>>>>>> Artur Malabarba <bruce.connor.am@gmail.com>:
>
>> I'd like to know whether it's ok to split it into two files,
>> package.el and package-menu.el?
>
>> The distinction is very logic, there's a ton of stuff that goes on in
>> package.el which doesn't make any use of the package-menu.
>> The only downside of this refactoring would be to mess up things like
>> `git-blame`, and that's why I'm askinghere.
>
> If you do
>  cp package.el package-menu.el
>  git add package-menu.el
>  git commit -m "Copying verbatim to preserve history"
>
> before you start working, and then do your changes by removing stuff
> from package-menu.el (and package.el) and not move things around
> otherwise, then git-blame should show the correct history.
>
>



  reply	other threads:[~2015-03-29 11:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-28  9:52 Organizing package.el a bit Artur Malabarba
2015-03-28 12:36 ` Stefan Monnier
2015-03-28 13:35   ` Artur Malabarba
2015-03-28 14:52     ` Artur Malabarba
2015-03-28 14:55       ` Oleh Krehel
2015-03-28 17:50         ` Artur Malabarba
2015-03-29  9:04 ` Steinar Bang
2015-03-29 11:06   ` Artur Malabarba [this message]
2015-03-29 12:56     ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAdUY-+TDrL=5ts9zxy23OfSnL=-dSYt7gGvbQkgDbfQ25kS0w@mail.gmail.com' \
    --to=bruce.connor.am@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).