From: Artur Malabarba <bruce.connor.am@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Glenn Morris <rgm@gnu.org>,
eggert@cs.ucla.edu, emacs-devel <emacs-devel@gnu.org>
Subject: Re: builds are getting slower?
Date: Wed, 16 Dec 2015 11:50:11 +0000 [thread overview]
Message-ID: <CAAdUY-+KkNyrBhQXEKOYSrEFA+xYkoeK1Vg+hQdZ7YhG3KTVEw@mail.gmail.com> (raw)
In-Reply-To: <83d1u73cz8.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On 15 Dec 2015 4:15 pm, "Eli Zaretskii" <eliz@gnu.org> wrote:
>
> Maybe I'm reading the code wrongly, but it looks like even before the
> cache could kick in, dir-locals-find-file calls
> locate-dominating-file, passing it dir-locals--all-files as its
> predicate. This has 2 effects: (a) it loads "seq", and (b) it calls
> file-expand-wildcards, which needs to read the entire directory and
> then match each file against a regexp.
>
> Could these be the cause of slowdown?
Probably. And no, You're not reading it wrong.
We need to locate the dir locals file(s) in order to compare its timestamp
to the cache. Do we have a faster way of expanding wildcards?
Maybe it would be faster to not allow wildcards at all, and just have a
fixed regexp that we use in directory-files.
If that doesn't help, then we could also forgo of the regexp, and just have
two allowed filenames (like .dir-locals.el and .dir-locals-2.el).
[-- Attachment #2: Type: text/html, Size: 1143 bytes --]
next prev parent reply other threads:[~2015-12-16 11:50 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:15 builds are getting slower? Glenn Morris
2015-12-10 2:41 ` Paul Eggert
2015-12-10 3:51 ` Glenn Morris
2015-12-10 6:53 ` Paul Eggert
2015-12-10 8:14 ` Artur Malabarba
2015-12-10 8:57 ` David Kastrup
2015-12-10 16:16 ` Eli Zaretskii
2015-12-10 17:27 ` Glenn Morris
2015-12-13 6:10 ` Paul Eggert
2015-12-13 21:53 ` Glenn Morris
2015-12-13 23:53 ` Glenn Morris
2015-12-14 3:31 ` Eli Zaretskii
2015-12-14 22:20 ` John Wiegley
2015-12-14 23:40 ` Paul Eggert
2015-12-15 0:38 ` John Wiegley
2015-12-15 8:13 ` Michael Albinus
2016-01-03 20:02 ` mark expensive tests (was: builds are getting slower?) Michael Albinus
2016-01-03 20:09 ` mark expensive tests John Wiegley
2016-01-03 20:40 ` Paul Eggert
2016-01-03 21:08 ` John Wiegley
2016-01-03 21:43 ` Paul Eggert
2016-01-03 21:45 ` John Wiegley
2016-01-04 3:18 ` Richard Stallman
2016-01-04 3:34 ` Paul Eggert
2016-01-04 8:16 ` Michael Albinus
2016-01-04 15:24 ` Paul Eggert
2016-01-04 15:31 ` Michael Albinus
2016-01-04 15:34 ` Dmitry Gutov
2016-01-04 15:43 ` Michael Albinus
2016-01-07 22:14 ` Phillip Lord
2016-01-08 8:58 ` Eli Zaretskii
2016-01-08 20:42 ` Achim Gratz
2016-01-09 0:21 ` John Wiegley
2016-01-09 12:09 ` Achim Gratz
2016-01-12 16:55 ` Simon Michael
2016-01-09 0:21 ` John Wiegley
2016-01-04 15:49 ` Eli Zaretskii
2016-01-04 15:48 ` Eli Zaretskii
2016-01-04 16:50 ` Paul Eggert
2016-01-04 17:18 ` Eli Zaretskii
2016-01-04 17:56 ` Paul Eggert
2016-01-04 15:47 ` Eli Zaretskii
2016-01-04 16:19 ` Michael Albinus
2016-01-04 16:51 ` Eli Zaretskii
2016-01-04 17:01 ` Michael Albinus
2016-01-04 17:23 ` Eli Zaretskii
2016-01-04 17:55 ` Michael Albinus
2016-01-04 22:30 ` Michael Albinus
2015-12-15 13:12 ` builds are getting slower? Phillip Lord
2015-12-15 8:18 ` Glenn Morris
2015-12-15 12:38 ` Artur Malabarba
2015-12-15 12:49 ` David Kastrup
2015-12-15 16:15 ` Eli Zaretskii
2015-12-16 11:50 ` Artur Malabarba [this message]
2015-12-16 11:58 ` Eli Zaretskii
2015-12-16 13:09 ` Artur Malabarba
2015-12-16 13:25 ` David Kastrup
2015-12-16 13:53 ` Eli Zaretskii
2015-12-17 2:11 ` Glenn Morris
2015-12-17 16:06 ` John Wiegley
2016-01-16 8:55 ` Artur Malabarba
2016-01-19 22:55 ` Glenn Morris
2016-01-20 0:04 ` Artur Malabarba
2016-01-26 1:46 ` Artur Malabarba
2016-01-26 18:52 ` Glenn Morris
2016-01-26 19:24 ` Stefan Monnier
2016-01-26 19:40 ` John Wiegley
2016-01-26 20:15 ` Artur Malabarba
2016-01-26 22:23 ` Paul Eggert
2016-01-29 1:29 ` John Wiegley
[not found] ` <CAAdUY-KaYN5L8wAyFpUYL=dVG2twMYQk4+iBH_cpW2fyMaHOow@mail.gmail.com>
2016-01-29 11:46 ` Artur Malabarba
2015-12-17 2:13 ` Glenn Morris
2015-12-15 19:25 ` Glenn Morris
2015-12-15 19:40 ` David Kastrup
-- strict thread matches above, loose matches on Subject: below --
2015-12-15 14:23 Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAdUY-+KkNyrBhQXEKOYSrEFA+xYkoeK1Vg+hQdZ7YhG3KTVEw@mail.gmail.com \
--to=bruce.connor.am@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).