From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sat, 31 Oct 2015 23:13:34 +0000 Message-ID: References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e01228934795d1f05236eb1a9 X-Trace: ger.gmane.org 1446333231 22628 80.91.229.3 (31 Oct 2015 23:13:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 23:13:51 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Stefan Monnier , emacs-devel To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 00:13:51 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsfLK-0007gy-Q1 for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 00:13:50 +0100 Original-Received: from localhost ([::1]:57286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfLK-0000L9-C2 for ged-emacs-devel@m.gmane.org; Sat, 31 Oct 2015 19:13:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfL6-0000L4-P2 for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:13:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsfL5-0000Gi-Sh for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:13:36 -0400 Original-Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:33733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfL5-0000GV-J0 for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:13:35 -0400 Original-Received: by lbbec13 with SMTP id ec13so68857201lbb.0 for ; Sat, 31 Oct 2015 16:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=EMFsvxoiI7kbaHZ3p/XQ/evRC8YhWTpjNVqg4GMqB1Q=; b=WSWELldmgnt8d8TaiIYVwCjKfpxuC/VX2vmK/toBUeEialDEOFg0yYfbggh4A6Ty4c bRmVvlHjl+uTBQsY8xG91eOMl75FBVdhfDquXSHe3M2MpekgEZdQXOn6v0ita5NHbd3D zru8Cphdaw4SfzYa/sy2XsuwNpvUQEl1EjsDF/JbLnweGNVhXoQt/O2bgZo/O7lvyzGY FMvMZ95I/beGMO+qDFgoiSXV65UwVuqsJkugOAaN8rUnqevxrbHTkefCpItRqBA5tBg0 ijxR8GVIMQSP1PUZK2od7tYhnXluEecLK/5XYSQ5Hk+lrsBQcf/KHBvMzcTkGwPib/MP ytzA== X-Received: by 10.112.135.233 with SMTP id pv9mr7058495lbb.42.1446333214447; Sat, 31 Oct 2015 16:13:34 -0700 (PDT) Original-Received: by 10.112.63.71 with HTTP; Sat, 31 Oct 2015 16:13:34 -0700 (PDT) Original-Received: by 10.112.63.71 with HTTP; Sat, 31 Oct 2015 16:13:34 -0700 (PDT) In-Reply-To: <20151029232302.GB3812@acm.fritz.box> X-Google-Sender-Auth: ApHX-jzTU7m1StmTVAd3RWZb5AE X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193038 Archived-At: --089e01228934795d1f05236eb1a9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29 Oct 2015 11:23 pm, "Alan Mackenzie" wrote: > > Hello, Stefan, hello, Emacs. > > Resuming a conversation from a year and a half ago, in it I had proposed > a patch which made isearch work properly in a Follow Mode set of > windows. In the end, you rejected my patch (in effect), because... > > On Fri, May 09, 2014 at 10:40:07PM -0400, Stefan Monnier wrote: > > > I must say I really dislike this hard-coding of follow-mode support in > > isearch.el. Isearch should not know so much about follow-mode and > > follow-mode should not know so much about Isearch either. > > > IOW we should try harder to come up with more general hooks. What if isearch just took into account all windows displaying current-buffer, instead of just the selected one? This wouldn=E2=80=99t involve anything specific to follow mode, and I belie= ve it would solve the issue, no? --089e01228934795d1f05236eb1a9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 29 Oct 2015 11:23 pm, "Alan Mackenzie" <acm@muc.de> wrote:
>
> Hello, Stefan, hello, Emacs.
>
> Resuming a conversation from a year and a half ago, in it I had propos= ed
> a patch which made isearch work properly in a Follow Mode set of
> windows.=C2=A0 In the end, you rejected my patch (in effect), because.= ..
>
> On Fri, May 09, 2014 at 10:40:07PM -0400, Stefan Monnier wrote:
>
> > I must say I really dislike this hard-coding of follow-mode suppo= rt in
> > isearch.el.=C2=A0 Isearch should not know so much about follow-mo= de and
> > follow-mode should not know so much about Isearch either.
>
> > IOW we should try harder to come up with more general hooks.

What if isearch just took into account all windows displayin= g current-buffer, instead of just the selected one?
This wouldn=E2=80=99t involve anything specific to follow mode, and I belie= ve it would solve the issue, no?

--089e01228934795d1f05236eb1a9--