From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Artur Malabarba Newsgroups: gmane.emacs.devel Subject: Re: Please add comments to isearch.el Date: Sun, 13 Dec 2015 01:01:22 +0000 Message-ID: References: <83fuzoojcn.fsf@gnu.org> <83poyd8kta.fsf@gnu.org> <20151211121617.GA3351@acm.fritz.box> <83y4d16txk.fsf@gnu.org> <83lh916jpp.fsf@gnu.org> <871tasbnhh.fsf@mail.linkov.net> <83d1uc6sdq.fsf@gnu.org> <874mfntfgq.fsf@mail.linkov.net> Reply-To: bruce.connor.am@gmail.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113fc2605ebae80526bd188d X-Trace: ger.gmane.org 1449968492 1720 80.91.229.3 (13 Dec 2015 01:01:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Dec 2015 01:01:32 +0000 (UTC) Cc: Alan Mackenzie , Eli Zaretskii , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 13 02:01:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a7v2Z-0002WH-Ae for ged-emacs-devel@m.gmane.org; Sun, 13 Dec 2015 02:01:31 +0100 Original-Received: from localhost ([::1]:53545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7v2Y-0002aw-Kk for ged-emacs-devel@m.gmane.org; Sat, 12 Dec 2015 20:01:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7v2V-0002ac-6I for emacs-devel@gnu.org; Sat, 12 Dec 2015 20:01:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7v2U-0005IU-6L for emacs-devel@gnu.org; Sat, 12 Dec 2015 20:01:27 -0500 Original-Received: from mail-lf0-x229.google.com ([2a00:1450:4010:c07::229]:34991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7v2S-0005Fj-Cb; Sat, 12 Dec 2015 20:01:24 -0500 Original-Received: by lfdl133 with SMTP id l133so99515910lfd.2; Sat, 12 Dec 2015 17:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=t7D/+VyjY246wf70r/R1+eo7/UsadE6y6/yibgJvvKU=; b=GAhjgRPapTKBgk0znTlORBvJ1UE2snK+9M8J0gdeHy9Xl9wJeLLpFXGw8YAYtTtJ6h OJbc8tN8O/8TsFo0PSkxe2YfvNVS6O909X/ZQlPiLXWQ1R8cTdem8vRX2vof6i3hJxl3 FMThOdrSYjfFlan7YaPv5q5upkrf6hJ/mEAJJJj18s2udq0NCrprW6XGrJnOvqpeiTc6 sIV3dc6zurmCzF9NSA9Icts3wiIFGeZ1azuQZQ5Ta5ovHuVb3six9PkGXJEv2kDu9PzT zYoEc55c8kCp4OHTyXlzJYTtazNMJA2mN2yKmip+Kym5c0RCPMYc3XrJJsI6phjqw8SF QDtQ== X-Received: by 10.25.137.7 with SMTP id l7mr8577146lfd.63.1449968483086; Sat, 12 Dec 2015 17:01:23 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sat, 12 Dec 2015 17:01:22 -0800 (PST) Original-Received: by 10.112.202.99 with HTTP; Sat, 12 Dec 2015 17:01:22 -0800 (PST) In-Reply-To: <874mfntfgq.fsf@mail.linkov.net> X-Google-Sender-Auth: Z0zNno8zNhtQRJtAAr5XmWmAShg X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196193 Archived-At: --001a113fc2605ebae80526bd188d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12 Dec 2015 11:27 pm, "Juri Linkov" wrote: > 1. Rename =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80=99 to dist= inguish between lax at the word/symbol > boundary and lax-whitespace to avoid confusion, so rename the > arg =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80=99 in all reg= exp-producing functions, > isearch--lax-regexp-function-p to > isearch--lax-boundary-regexp-function-p, etc. +1 > 2. Try to find a better common naming scheme used for the > regexp-producing functions word-search-regexp, isearch-symbol-regexp, > character-fold-to-regexp. I think the first two shouldn't even be in isearch.el. There's a ton of stuff in isearch.el that's just generally useful in searches (nothing specific to incremental search), and should be moved to some search.el file. > 3. Use well established terminology that shortens the prefixes > of character-related functions to just char- to use char-fold. > =E2=80=98C-h f char TAB=E2=80=99 or =E2=80=98C-h v char TAB=E2=80=99 s= hows the standard > Emacs naming convention. > > 4. Use the upper-case standard name =E2=80=9CUnicode=E2=80=9D in the docu= mentation. I don't see what these have to do with the readability of isearch el, but by all means, feel free to do these. =F0=9F=91=8D --001a113fc2605ebae80526bd188d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 12 Dec 2015 11:27 pm, "Juri Linkov" <juri@linkov.net> wrote:
> 1. Rename =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80=99 to d= istinguish between lax at the word/symbol
> =C2=A0 =C2=A0boundary and lax-whitespace to avoid confusion, so rename= the
> =C2=A0 =C2=A0arg =E2=80=98lax=E2=80=99 to =E2=80=98lax-boundary=E2=80= =99 in all regexp-producing functions,
> =C2=A0 =C2=A0isearch--lax-regexp-function-p to
> =C2=A0 =C2=A0isearch--lax-boundary-regexp-function-p, etc.

+1

> 2. Try to find a better common naming scheme used for t= he
> =C2=A0 =C2=A0regexp-producing functions word-search-regexp, isearch-sy= mbol-regexp,
> =C2=A0 =C2=A0character-fold-to-regexp.

I think the first two shouldn't even be in isearch.el. T= here's a ton of stuff in isearch.el that's just generally useful in= searches (nothing specific to incremental search), and should be moved to = some search.el file.

> 3. Use well established terminology that shortens the p= refixes
> =C2=A0 =C2=A0of character-related functions to just char- to use char-= fold.
> =C2=A0 =C2=A0=E2=80=98C-h f char TAB=E2=80=99 or =E2=80=98C-h v char T= AB=E2=80=99 shows the standard
> =C2=A0 =C2=A0Emacs naming convention.
>
> 4. Use the upper-case standard name =E2=80=9CUnicode=E2=80=9D in the d= ocumentation.

I don't see what these have to do with the readability o= f isearch el, but by all means, feel free to do these. =F0=9F=91=8D

--001a113fc2605ebae80526bd188d--