[PATCH] image-mode.el (image-kill-buffer): New command.

[PATCH] image-mode.el (image-kill-buffer): New command.

[Artur Malabarba]

Given how similar docview and image-mode are, I'm always taken
off-guard when I run into a small difference. This patch fixes one.

k kills the buffer in docview, and I see no reason why it wouldn't do
the same in image-mode. If nobody opposes this patch I'll merge it
myself.

Cheers to all,

Re: [PATCH] image-mode.el (image-kill-buffer): New command.

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

Forgot to attach the patch. Sorry.

2015-02-04 20:11 GMT-02:00 Artur Malabarba <bruce.connor.am@gmail.com>:
> Given how similar docview and image-mode are, I'm always taken
> off-guard when I run into a small difference. This patch fixes one.
>
> k kills the buffer in docview, and I see no reason why it wouldn't do
> the same in image-mode. If nobody opposes this patch I'll merge it
> myself.
>
> Cheers to all,

[-- Attachment #2: 0001-image-mode.el-image-kill-buffer-New-command.patch --]
[-- Type: text/x-patch, Size: 1711 bytes --]

From fa7711bf92aaf86087af5fdfbb5e25ad1540fabb Mon Sep 17 00:00:00 2001
From: Artur Malabarba <bruce.connor.am@gmail.com>
Date: Wed, 4 Feb 2015 18:02:14 -0200
Subject: [PATCH] * image-mode.el (image-kill-buffer): New command.

---
 lisp/ChangeLog     | 3 +++
 lisp/image-mode.el | 7 +++++++
 2 files changed, 10 insertions(+)

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 9e473e2..15d79b4 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -14,6 +14,9 @@
 
 2015-02-04  Artur Malabarba  <bruce.connor.am@gmail.com>
 
+	* image-mode.el (image-kill-buffer): New command.
+	(image-mode-map): Bind it to k.
+
 	* emacs-lisp/package.el (package-delete): Remove package from
 	`package-selected-packages' even if it can't be deleted.
 	(package-installed-p): Accept package-desc objects.
diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 9e527f1..8ea1a2b 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -380,6 +380,7 @@ call."
     (define-key map "a-" 'image-decrease-speed)
     (define-key map "a0" 'image-reset-speed)
     (define-key map "ar" 'image-reverse-speed)
+    (define-key map "k" 'image-kill-buffer)
     (define-key map [remap forward-char] 'image-forward-hscroll)
     (define-key map [remap backward-char] 'image-backward-hscroll)
     (define-key map [remap right-char] 'image-forward-hscroll)
@@ -722,6 +723,12 @@ the image by calling `image-mode'."
       (image-mode-as-text)
     (image-mode)))
 
+(defun image-kill-buffer ()
+  "Kill the current buffer."
+  (interactive)
+  (when (eq major-mode 'image-mode)
+    (kill-buffer (current-buffer))))
+
 (defun image-after-revert-hook ()
   (when (image-get-display-property)
     (image-toggle-display-text)
-- 
2.2.2

Re: [PATCH] image-mode.el (image-kill-buffer): New command.

[Stefan Monnier]

>> Given how similar docview and image-mode are, I'm always taken
>> off-guard when I run into a small difference. This patch fixes one.

They should share more behavior *and* code.

> +	* image-mode.el (image-kill-buffer): New command.
> +	(image-mode-map): Bind it to k.

Could you try and remove the "k" binding in doc-view-map (i.e. let it
inherit from image-mode-map)?


        Stefan

Re: [PATCH] image-mode.el (image-kill-buffer): New command.

[Artur Malabarba]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

> Could you try and remove the "k" binding in doc-view-map (i.e. let it
> inherit from image-mode-map)?
>

Unfortunately it won't be that simple. Docview's command is different
because it also kills the conversion process.

[-- Attachment #2: Type: text/html, Size: 292 bytes --]

Re: [PATCH] image-mode.el (image-kill-buffer): New command.

[Stefan Monnier]

>> Could you try and remove the "k" binding in doc-view-map (i.e. let it
>> inherit from image-mode-map)?
> Unfortunately it won't be that simple. Docview's command is different
> because it also kills the conversion process.

I know, but I think it will either "just work" (thanks to the
kill-buffer-hook), or can be made to work.


        Stefan