From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Manheimer Newsgroups: gmane.emacs.devel Subject: Re: master 89898fc: Repair pdbtrack so it follows transition from one remote file to another. Date: Sun, 20 Sep 2015 11:59:46 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ec146c11bd505202fdb7a X-Trace: ger.gmane.org 1442764820 5993 80.91.229.3 (20 Sep 2015 16:00:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Sep 2015 16:00:20 +0000 (UTC) To: "emacs-devel@gnu.org" , Eli Zaretskii , Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 20 18:00:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zdh2I-0006ak-Jy for ged-emacs-devel@m.gmane.org; Sun, 20 Sep 2015 18:00:19 +0200 Original-Received: from localhost ([::1]:52551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdh2H-0006w3-EP for ged-emacs-devel@m.gmane.org; Sun, 20 Sep 2015 12:00:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdh2B-0006s6-GU for emacs-devel@gnu.org; Sun, 20 Sep 2015 12:00:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zdh2A-0001e8-AR for emacs-devel@gnu.org; Sun, 20 Sep 2015 12:00:11 -0400 Original-Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:33144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdh26-0001YC-H3; Sun, 20 Sep 2015 12:00:06 -0400 Original-Received: by iofh134 with SMTP id h134so98841119iof.0; Sun, 20 Sep 2015 09:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=KhFW//mgspXQktKoZ4GIOfoRXFTl2y3zUuBNz33dpEo=; b=NJdF3yFWK2u5PK8a0EVqmPgyhSwR+ZwuThZ8LQ004IenRMtuALF7B7dUVoF3k6oM0m 8ki8YThDXAGx/iR887ZhkBIHWtCLX0jO4rnSK77wI1U9w4v61CuW+lz/EJJuxzI33dB6 k7elEaePyQgjWxPH5hqA118hJNkS/Jor72Qos++J8NucC72bQShRBvpkZF1xxCq+rGX+ 5D82i8kM+1pCxWhOLVs//oyAPPQ0X/FniPFBbnBOE4FIPiH5mSrGT5BFy4DDAv7QzE6+ JN4LNnJRdqc0eyW1wwH1atMbNFrJVx3iEO5qL10IlVQ4P/YweTa55V80VD9HpOu/1ySx mYBA== X-Received: by 10.107.9.212 with SMTP id 81mr21950382ioj.191.1442764805968; Sun, 20 Sep 2015 09:00:05 -0700 (PDT) Original-Received: by 10.64.102.231 with HTTP; Sun, 20 Sep 2015 08:59:46 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c06::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190140 Archived-At: --001a113ec146c11bd505202fdb7a Content-Type: text/plain; charset=UTF-8 [Whoops - inadvertently sent my reply only to Glenn, so re-sending to all. I have a push ready for origin/master with the amended commit and the ChangeLog.17 entry removed, just waiting for affirmation that amending is the right thing to do. Details and another question are in-line below.] On Sun, Sep 20, 2015 at 6:44 AM, Glenn Morris wrote: > ken manheimer wrote: > > > * python.el (python-pdbtrack-set-tracked-buffer). > > Should have been: > > * lisp/python.el (python-pdbtrack-set-tracked-buffer): Do something. > > > --- a/lisp/ChangeLog.17 > > +++ b/lisp/ChangeLog.17 > > @@ -1,3 +1,8 @@ > > +2015-09-20 Ken Manheimer > > + > > + * python.el (python-pdbtrack-set-tracked-buffer): Repair pdbtrack > > + so it follows transition from one remote file to another. > > + > > 2015-04-06 Alan Mackenzie > > Please remove this addition. > ChangeLogs are auto-generated for some time. > Did you think no-one had made a change for the past 5 months, or that we > renamed the Changelog to "ChangeLog.17"? ;) > Ok. I have a few questions for you. I am clear that I should remove the ChangeLog.17 entry, and can easily do that with an additional, cumulative commit. I gather my commit message for the code change should have been: Repair pdbtrack remote file tracking * lisp/progmodes/python.el (python-pdbtrack-set-tracked-buffer): Rectify pdbtrack so it follows transition from one remote file to another. I think I am able to `git amend` the original code commit, but I have very rarely done that, and am not sure it's the right thing, besides. So: should I amend 89898fc, or just do another, distinct commit? Also, I have finally found the location of guidance for commit messages - CONTRIBUTORS in the source directory root. I had looked for guidance in http://www.emacswiki.org/emacs/GitForEmacsDevs - it would have be helpful if that prominently directed contributors to the CONTRIBUTORS file. Perhaps I'm just oblivious, but it seems like the various guidance resources are scattered enough that there is not an unmissable "garden path" to fill people in. Ken --001a113ec146c11bd505202fdb7a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
[Whoops - inadvertently sent my reply only to Glenn, so re= -sending to all. I have a push ready for origin/master with the amended com= mit and the ChangeLog.17 entry removed, just waiting for affirmation that a= mending is the right thing to do. Details and another question are in-line = below.]

On Sun, Sep 20, 2015 at 6:44 AM, Glenn Morris <= ;rgm@gnu.org> wrote:
ken manheimer wrote:

>=C2=A0 =C2=A0 =C2=A0* python.el (python-pdbtrack-set-tracked-buffer).
Should have been:

* lisp/python.el (python-pdbtrack-set-tracked-buffer): Do something.

> --- a/lisp/ChangeLog.17
> +++ b/lisp/ChangeLog.17
> @@ -1,3 +1,8 @@
> +2015-09-20=C2=A0 Ken Manheimer=C2=A0 <ken.manheimer@gmail.com>
> +
> +=C2=A0 =C2=A0 =C2=A0* python.el (python-pdbtrack-set-tracked-buffer):= Repair pdbtrack
> +=C2=A0 =C2=A0 =C2=A0so it follows transition from one remote file to = another.
> +
>=C2=A0 2015-04-06=C2=A0 Alan Mackenzie=C2=A0 <acm@muc.de>

Please remove this addition.
ChangeLogs are auto-generated for some time.
Did you think no-one had made a change for the past 5 months, or that we renamed the Changelog to "ChangeLog.17"? ;)
=
Ok. I have a few questions for you.
I am clear that I should remove the=C2=A0ChangeLog.17 entry, a= nd can easily do that with an additional, cumulative commit.

=
I gather my commit message for the code change should have been:=

Repair pdbtrack remote file trac= king

= * lisp/progmodes/python.el (python-pdbtrack-= set-tracked-buffer): Rectify pdbtrack= so it follows transition from one re= mote file to another.

I think I am able= to `git amend` the original code commit, but I have very rarely done that,= and am not sure it's the right thing, besides. So: should I amend=C2= =A089898fc, or just do another, disti= nct commit?

= Also, I have finally found the location of guidance for commit messages - C= ONTRIBUTORS in the source directory root. I had looked for guidance in=C2= =A0http://www.emacswiki.org/emacs/GitForEmacsDevs=C2=A0- it wo= uld have be helpful if that prominently directed contributors to the CONTRI= BUTORS file. Perhaps I'm just oblivious, but it seems like the various = guidance resources are scattered enough that there is not an unmissable &qu= ot;garden path" to fill people in.

Ken




--001a113ec146c11bd505202fdb7a--