Re: master 89898fc: Repair pdbtrack so it follows transition from one remote file to another.

[Ken Manheimer <ken.manheimer@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

[Whoops - inadvertently sent my reply only to Glenn, so re-sending to all.
I have a push ready for origin/master with the amended commit and the
ChangeLog.17 entry removed, just waiting for affirmation that amending is
the right thing to do. Details and another question are in-line below.]

On Sun, Sep 20, 2015 at 6:44 AM, Glenn Morris <rgm@gnu.org> wrote:

> ken manheimer wrote:
>
> >     * python.el (python-pdbtrack-set-tracked-buffer).
>
> Should have been:
>
> * lisp/python.el (python-pdbtrack-set-tracked-buffer): Do something.
>
> > --- a/lisp/ChangeLog.17
> > +++ b/lisp/ChangeLog.17
> > @@ -1,3 +1,8 @@
> > +2015-09-20  Ken Manheimer  <ken.manheimer@gmail.com>
> > +
> > +     * python.el (python-pdbtrack-set-tracked-buffer): Repair pdbtrack
> > +     so it follows transition from one remote file to another.
> > +
> >  2015-04-06  Alan Mackenzie  <acm@muc.de>
>
> Please remove this addition.
> ChangeLogs are auto-generated for some time.
> Did you think no-one had made a change for the past 5 months, or that we
> renamed the Changelog to "ChangeLog.17"? ;)
>

Ok. I have a few questions for you.

I am clear that I should remove the ChangeLog.17 entry, and can easily do
that with an additional, cumulative commit.

I gather my commit message for the code change should have been:

Repair pdbtrack remote file tracking

* lisp/progmodes/python.el (python-pdbtrack-set-tracked-buffer): Rectify
pdbtrack so it follows transition from one remote file to another.


I think I am able to `git amend` the original code commit, but I have very
rarely done that, and am not sure it's the right thing, besides. So: should
I amend 89898fc, or just do another, distinct commit?

Also, I have finally found the location of guidance for commit messages -
CONTRIBUTORS in the source directory root. I had looked for guidance in
http://www.emacswiki.org/emacs/GitForEmacsDevs - it would have be helpful
if that prominently directed contributors to the CONTRIBUTORS file. Perhaps
I'm just oblivious, but it seems like the various guidance resources are
scattered enough that there is not an unmissable "garden path" to fill
people in.

Ken

[-- Attachment #2: Type: text/html, Size: 3771 bytes --]