* Broken bootstrap in r113623
@ 2013-07-31 14:45 Dmitry Antipov
2013-07-31 16:28 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Antipov @ 2013-07-31 14:45 UTC (permalink / raw)
To: Emacs development discussions; +Cc: Xue Fuqiao
...
make[3]: Entering directory `/home/dima/work/stuff/emacs/trunk/build-debug/doc/emacs'
/bin/makeinfo --force --enable-encoding -I /home/dima/work/stuff/emacs/trunk/doc/emacs --no-split -o /home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info
/home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi
/home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi:547: Cross reference to nonexistent node `Disabling Multibyte' (perhaps incorrect sectioning?).
make[3]: *** [/home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info] Error 1
...
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Broken bootstrap in r113623
2013-07-31 14:45 Broken bootstrap in r113623 Dmitry Antipov
@ 2013-07-31 16:28 ` Eli Zaretskii
2013-07-31 23:15 ` Xue Fuqiao
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2013-07-31 16:28 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: xfq.free, emacs-devel
> Date: Wed, 31 Jul 2013 18:45:43 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Cc: Xue Fuqiao <xfq.free@gmail.com>
>
> ...
> make[3]: Entering directory `/home/dima/work/stuff/emacs/trunk/build-debug/doc/emacs'
> /bin/makeinfo --force --enable-encoding -I /home/dima/work/stuff/emacs/trunk/doc/emacs --no-split -o /home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi:547: Cross reference to nonexistent node `Disabling Multibyte' (perhaps incorrect sectioning?).
> make[3]: *** [/home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info] Error 1
> ...
Fixed.
Xue, please in the future always run "make info" whenever you make any
changes in the manual. Otherwise, the risk of gratuitously breaking
the build is quite high.
Please also make a point of mentioning _all_ of your changes in
ChangeLog entries (in this case, the removal of the "Disabling
Multibyte" node was never mentioned).
Finally, please use meaningful commit messages. Something like "Doc
fix" does not have any meaningful information, and thus is useless.
We use "Doc fix" when making changes to doc strings of Lisp functions,
but then we always state the name of the function whose doc string was
fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
a good idea. Think about the plight of someone who wants to get a
quick overview of a series of changes by doing "bzr log -l10 --line".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Broken bootstrap in r113623
2013-07-31 16:28 ` Eli Zaretskii
@ 2013-07-31 23:15 ` Xue Fuqiao
0 siblings, 0 replies; 3+ messages in thread
From: Xue Fuqiao @ 2013-07-31 23:15 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Thu, Aug 1, 2013 at 12:28 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> Xue, please in the future always run "make info" whenever you make any
> changes in the manual. Otherwise, the risk of gratuitously breaking
> the build is quite high.
>
> Please also make a point of mentioning _all_ of your changes in
> ChangeLog entries (in this case, the removal of the "Disabling
> Multibyte" node was never mentioned).
>
> Finally, please use meaningful commit messages. Something like "Doc
> fix" does not have any meaningful information, and thus is useless.
> We use "Doc fix" when making changes to doc strings of Lisp functions,
> but then we always state the name of the function whose doc string was
> fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
> a good idea. Think about the plight of someone who wants to get a
> quick overview of a series of changes by doing "bzr log -l10 --line".
I see, thanks.
--
Best regards, Xue Fuqiao.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-31 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 14:45 Broken bootstrap in r113623 Dmitry Antipov
2013-07-31 16:28 ` Eli Zaretskii
2013-07-31 23:15 ` Xue Fuqiao
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).