From: Xue Fuqiao <xfq.free@gmail.com>
To: John Anthony <john@jo.hnanthony.com>
Cc: emacs-devel@gnu.org
Subject: Re: Hello / First contribution / Major Mode menu entries
Date: Wed, 2 Oct 2013 22:16:22 +0800 [thread overview]
Message-ID: <CAAF+z6EgxcNLtOJkN90AMSV6waphPNDTK-qdK5XuK-VMtPSMcg@mail.gmail.com> (raw)
In-Reply-To: <20131002052755.GA6413@jo.hnanthony.com>
On Wed, Oct 2, 2013 at 1:27 PM, John Anthony <john@jo.hnanthony.com> wrote:
> Hey there, guys.
>
> I'm interested in taking care of a bunch of the little TODO items in
> etc/TODO. I've read etc/CONTRIBUTE and understand that there are
> special considerations when contributing to emacs and other FSF
> projects. I thought I'd start by handling the major mode menu items
> mentioned on line 65 of etc/TODO. I thought I'd get some feedback
> before I steam in and do a bunch:
>
>
> diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
> index d9ff04c..367a84a 100644
> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> @@ -192,4 +192,22 @@ The argument NLINES says how many lines to center."
> (setq nlines (1+ nlines))
> (forward-line -1)))))
>
> +(easy-menu-define text-mode-menu text-mode-map
> + "Menu for Text mode."
> + '("Text Mode"
> + ["Center Line" center-line
> + :help "Center the current line"
> + :active t]
> + ["Center Lines" (lambda (n)
> + (interactive "nNumber of lines to indent: ")
> + (center-line n))
> + :help "Center several lines"
> + :active t]
> + ["Center Paragraph" center-paragraph
> + :help "Center the current paragraph"
> + :active t]
> + ["Center Region" center-region
> + :help "Center the selected region"
> + :active (region-active-p)]))
> ;;; text-mode.el ends here
>
>
> When I post such patches to bug-gnu-emacs.org would I be better off
> submitting a diff generated by bzr?
Using ‘diff -c’ to make your diffs is recommended. See (info "(emacs)
Sending Patches").
> This is my first message to emacs-devel and I'm vaguely aware of the
> fact that I may not be doing things correctly. I'd very much
> appreciate any help/advice I could get.
Thanks for wanting to contribute, welcome, and do not hesitate to ask
any further question, we are here to help!
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/
next prev parent reply other threads:[~2013-10-02 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 5:27 Hello / First contribution / Major Mode menu entries John Anthony
2013-10-02 14:16 ` Xue Fuqiao [this message]
2013-10-03 0:04 ` John Anthony
2013-10-03 1:03 ` Stephen J. Turnbull
2013-10-03 3:38 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2013-10-01 20:48 j.anthony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAF+z6EgxcNLtOJkN90AMSV6waphPNDTK-qdK5XuK-VMtPSMcg@mail.gmail.com \
--to=xfq.free@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=john@jo.hnanthony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).