From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Zoltan Kemenczy" Newsgroups: gmane.emacs.devel Subject: RE: [janneke@gnu.org: jdb line fix for gud] Date: Wed, 28 Jan 2004 20:54:45 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1075341387 8159 80.91.224.253 (29 Jan 2004 01:56:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2004 01:56:27 +0000 (UTC) Cc: rms@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Jan 29 02:56:18 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Am1Pm-0008CQ-00 for ; Thu, 29 Jan 2004 02:56:18 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1Am1Pm-0000Fw-00 for ; Thu, 29 Jan 2004 02:56:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Am1PB-0007Wf-IF for emacs-devel@quimby.gnus.org; Wed, 28 Jan 2004 20:55:41 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1Am1Or-0007WG-6e for emacs-devel@gnu.org; Wed, 28 Jan 2004 20:55:21 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Am1OL-0007Qv-AB for emacs-devel@gnu.org; Wed, 28 Jan 2004 20:55:20 -0500 Original-Received: from [216.9.243.101] (helo=mhs99ykf.rim.net) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Am1OL-0007Qq-0K; Wed, 28 Jan 2004 20:54:49 -0500 Original-Received: from ngw04ykf.rim.net (ngw04ykf.rim.net [10.102.100.115]) by mhs99ykf.rim.net (Postfix) with SMTP id 39846B9456; Wed, 28 Jan 2004 20:54:45 -0500 (EST) Original-Received: from XCH21YKF.rim.net ([10.102.100.36]) by ngw04ykf.rim.net (NAVGW 2.5.2.9) with SMTP id M2004012820544505853 ; Wed, 28 Jan 2004 20:54:45 -0500 Original-Received: from XCH26YKF.rim.net ([10.102.100.41]) by XCH21YKF.rim.net with Microsoft SMTPSVC(5.0.2195.6713); Wed, 28 Jan 2004 20:54:45 -0500 X-MimeOLE: Produced By Microsoft Exchange V6.0.6375.0 content-class: urn:content-classes:message X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [janneke@gnu.org: jdb line fix for gud] Thread-Index: AcPlfd143lD4jphSS4qy+aZdrkuLjgAiskLA Original-To: X-OriginalArrivalTime: 29 Jan 2004 01:54:45.0879 (UTC) FILETIME=[DED0C070:01C3E60A] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19533 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19533 This an acceptable fix in my opinion (I test-drove it too). That regexp = group is limited to matching the line number only and since (until:-) = line numbers output from jdb get decimals, we should be ok. Thanks for the fix... I have no idea right now how to get at the LOCALE = variables in a platform-independent way. Someone may have a suggestion? Regards, Zoltan ------------------------------------------------------------------- To: emacs-devel@gnu.org From: Jan Nieuwenhuizen Organization: Jan at Appel Date: Mon, 26 Jan 2004 12:16:33 +0100 X-RBL-Warning: (inputs.orbz.org)=20 X-RBL-Warning: (outputs.orbz.org)=20 Subject: jdb line fix for gud Sender: emacs-devel-bounces+rms=3Dgnu.org@gnu.org Hi, Find a small fix for jdb below. Is this acceptable, or should `[.,]' be replaced by the actual LOCALE's thousands separator (how?). Jan. Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.5622 diff -p -u -r1.5622 ChangeLog - --- ChangeLog 25 Jan 2004 23:59:57 -0000 1.5622 +++ ChangeLog 26 Jan 2004 11:02:59 -0000 @@ -1,3 +1,9 @@ +2004-01-26 Jan Nieuwenhuizen + + * progmodes/gud.el (gud-jdb-marker-filter): Add period as optional + thousands separator; fixes : regexp for + non-english locales. + 2004-01-25 Glenn Morris =20 * progmodes/fortran.el (fortran-break-before-delimiters): Doc fix.=20 Index: progmodes/gud.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/emacs/emacs/lisp/progmodes/gud.el,v retrieving revision 1.15 diff -p -u -r1.15 gud.el - --- progmodes/gud.el 7 Jan 2004 23:22:34 -0000 1.15 +++ progmodes/gud.el 26 Jan 2004 11:02:59 -0000 @@ -1967,14 +1967,14 @@ nil) ;; FIXME: Java ID's are UNICODE strings, this matches ASCII ;; ID's only. ;; - - ;; The "," in the last square-bracket is necessary because = of - - ;; Sun's total disrespect for backwards compatibility in + ;; The ".," in the last square-bracket are necessary because + ;; of Sun's total disrespect for backwards compatibility in ;; reported line numbers from jdb - starting in 1.4.0 they - - ;; introduced a comma at the thousands position (how - - ;; ingenious!) + ;; print line numbers using LOCALE, inserting a comma or a + ;; period at the thousands positions (how ingenious!). =20 "\\(\[[0-9]+\] \\)*\\([a-zA-Z0-9.$_]+\\)\\.[a-zA-Z0-9$_<>(),]+ \ - -\\(([a-zA-Z0-9.$_]+:\\|line=3D\\)\\([0-9,]+\\)" +\\(([a-zA-Z0-9.$_]+:\\|line=3D\\)\\([0-9.,]+\\)" gud-marker-acc) =20 ;; A good marker is one that: @@ -2001,7 +2001,7 @@ nil) (string-to-int (let ((numstr (match-string 4 = gud-marker-acc))) - - (if (string-match "," numstr) + (if (string-match "[.,]" numstr) (replace-match "" nil nil numstr) numstr))))) (message "Could not find source file."))) - --=20 Jan Nieuwenhuizen | GNU LilyPond - The music = typesetter http://www.xs4all.nl/~jantien | http://www.lilypond.org _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel