From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jaesup Kwak Newsgroups: gmane.emacs.devel Subject: Re: Xwidget webkit support for macOS X Cocoa Date: Tue, 5 Dec 2017 02:08:13 +0900 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114697de86509c055f86c38f" X-Trace: blaine.gmane.org 1512407308 30902 195.159.176.226 (4 Dec 2017 17:08:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Dec 2017 17:08:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Charles A. Roelli" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 04 18:08:23 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLuEB-0007my-E7 for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 18:08:23 +0100 Original-Received: from localhost ([::1]:44302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLuEH-0002IN-HQ for ged-emacs-devel@m.gmane.org; Mon, 04 Dec 2017 12:08:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLuE5-0002GQ-HW for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:08:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLuE3-00040k-HJ for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:08:16 -0500 Original-Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLuE3-0003zo-6N for emacs-devel@gnu.org; Mon, 04 Dec 2017 12:08:15 -0500 Original-Received: by mail-wm0-x22c.google.com with SMTP id f140so15607285wmd.2 for ; Mon, 04 Dec 2017 09:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Xx/Fs5qpzYacBLkr2epgSBnlXFn/6+stMEoEFJ3De3s=; b=fzJzjY/QTPZf3pIeFW6bxBTHQFUoSqmHc88zHthNJnAjo7PGO00PuDlZKdD7samKs1 LM0+fIjQKIVT7Ofh1QR2fSlj0/aFTQgqK2K3CZYlXZ1QYQKTeahxGsz0gWxYtz+eu8TG c/5zlEk2e3hjkVjTuogTsqn/wWXNDrTMAcYn6nY/Ad7KHiCyUZFUkbu1GvCcqS6CftTS vXoZLTSQzGSHe7q5ZB/sB32qkyMFS0N3rkXDDl/Ii9+QyWRafTYsiCmRyRK5GhmJ19rT LdlDCbVnYIOFVQnYiclHlqwpS4dYoByHelgvVfdGGPAr8Ajs8UZHn7zxB/HFgEQVR5Tb 9nVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Xx/Fs5qpzYacBLkr2epgSBnlXFn/6+stMEoEFJ3De3s=; b=llUNDkqcXsg6UU0G2YtAqC8XhR92ra9RBLOWK7KspoM2lWr6tlTdifCKcwy3my5JIz z0D5xGA+Q75Ei9CvSnADgLZxSU9MaHIEUhcEDspeyd50WxLOL0/s94BPHFtDAluP+d9u 0D3fwmpP0rMtnktGDYPOjRiREJEBQTB7++NYHaAzQv4U8hK5qtIrWgnS0zoogqv8aGdt dTbIHnt3kyW3IJccJnjQjQ3TV5ASiveUpwSpeMD6XPAfMIZPNiA6Zh5ju6mgWUL01wN0 10T7MecV9NR5yOmJSN/ZmZN6QDFFcYpHhFPckf8IPX54lKwKmVzjRQQLAA1AvjK/iTXQ FviQ== X-Gm-Message-State: AKGB3mIYYwAm+ggRhUSvQ8CQik9/YFd3bt//DMOx5gZ6HqqSUsgfJsy6 115kGD2P4Y17alhnTIJl00/ck7t7ugsrCockDMUMeA== X-Google-Smtp-Source: AGs4zMaj/VpSSdTizQbHHSbYoABgqXYgkxKDwfXfE9/7uFDI38gGBCC41DwMRJRhfCoipRR19v7wLcYCi5nbNR5OWd4= X-Received: by 10.28.212.148 with SMTP id l142mr3265064wmg.99.1512407294167; Mon, 04 Dec 2017 09:08:14 -0800 (PST) Original-Received: by 10.28.227.67 with HTTP; Mon, 4 Dec 2017 09:08:13 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220711 Archived-At: --001a114697de86509c055f86c38f Content-Type: text/plain; charset="UTF-8" I rebased my changes so far against the latest master and posted a patch to bug-gnu-emacs@gnu.org with the Subject of "[PATCH] Support xwidget webkit for macOS X". I made some effort to write good commit log after reading the ChangeLog guide. Thanks for your advice and work about the macOS support policy. On Sun, Dec 3, 2017 at 8:32 PM, Charles A. Roelli wrote: > > From: Jaesup Kwak > > Date: Tue, 28 Nov 2017 16:13:45 +0900 > > > > Hi all! > > > > I made a work supporting Emacs xwidget webkit for macOS X, which works > with Cocoa and Safari webkit frameworks without need of > > GTK and X window. You can t ry it on master branch of > https://github.com/veshboo/emacs > > > > I want to contribute the work to GNU Emacs and hope someone help me how > to contribute. > > > > Thank you. > > Thanks a lot for implementing xwidget on macOS. Could you please > rebase your branch against the latest master, and post a patch to > bug-gnu-emacs@gnu.org? The ChangeLog will also have to be in the > format as specified here: > > https://www.gnu.org/prep/standards/html_node/Change-Logs.html > > (It's best to use `C-x 4 a' and then the standard VC bindings to make > commits, so that the right style is used. The ChangeLog messages will > be automatically copied into the commit message when you commit files > with `C-x v v'.) > > Generally Emacs tries to keep support for macOS 10.6 and above, even > for new development. I saw that you used the WKWebView as a parent > class for the XwWebView, which was made available in version 10.10. I > made some small changes locally to adapt your branch to build with the > older "WebView" class, and it works on 10.6 (but it is missing some of > the bells and whistles). I will work on it some more this week, and > we can hopefully include it along with your xwidget implementation. > > Thanks again. > --001a114697de86509c055f86c38f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I rebased my changes so far against the latest master= and posted a
patch to b= ug-gnu-emacs@gnu.org with the Subject of
"[PATCH] Suppor= t xwidget webkit for macOS X".

I made some ef= fort to write good commit log after reading the
ChangeLog guide.<= /div>

Thanks for your advice and work about the macOS su= pport policy.


On Sun, Dec 3, 2017 at 8:32 PM, Charles A. Roelli <c= harles@aurox.ch> wrote:
>= ; From: Jaesup Kwak <veshboo@gmail.= com>
> Date: Tue, 28 Nov 2017 16:13:45 +0900
>
> Hi all!
>
> I made a work supporting Emacs xwidget webkit for macOS X, which works= with Cocoa and Safari webkit frameworks without need of
> GTK and X window. You can t ry it on master branch of https://g= ithub.com/veshboo/emacs
>
> I want to contribute the work to GNU Emacs and hope someone help me ho= w to contribute.
>
> Thank you.

Thanks a lot for implementing xwidget on macOS.=C2=A0 Could you= please
rebase your branch against the latest master, and post a patch to
bug-gnu-emacs@gnu.org?=C2=A0 T= he ChangeLog will also have to be in the
format as specified here:

https://www.gnu.org/prep/standards= /html_node/Change-Logs.html

(It's best to use `C-x 4 a' and then the standard VC bindings to ma= ke
commits, so that the right style is used.=C2=A0 The ChangeLog messages will=
be automatically copied into the commit message when you commit files
with `C-x v v'.)

Generally Emacs tries to keep support for macOS 10.6 and above, even
for new development.=C2=A0 I saw that you used the WKWebView as a parent class for the XwWebView, which was made available in version 10.10.=C2=A0 I=
made some small changes locally to adapt your branch to build with the
older "WebView" class, and it works on 10.6 (but it is missing so= me of
the bells and whistles).=C2=A0 I will work on it some more this week, and we can hopefully include it along with your xwidget implementation.

Thanks again.

--001a114697de86509c055f86c38f--